[PATCH 14/16] event/dpaa: fix bitmask truncation
Hemant Agrawal
hemant.agrawal at oss.nxp.com
Mon Nov 18 08:04:10 CET 2024
On 15-11-2024 11:35, Stephen Hemminger wrote:
> More bitmask truncation from mask computation.
>
> Fixes: 0ee17f79ebd0 ("event/dpaa: add enqueue/dequeue")
> Cc: sunil.kori at nxp.com
> Cc: stable at dpdk.org
>
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> ---
> drivers/event/dpaa/dpaa_eventdev.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c
> index 853cc1ecf9..400e0ecd1c 100644
> --- a/drivers/event/dpaa/dpaa_eventdev.c
> +++ b/drivers/event/dpaa/dpaa_eventdev.c
> @@ -102,7 +102,7 @@ dpaa_event_enqueue_burst(void *port, const struct rte_event ev[],
> qman_dca_index(ev[i].impl_opaque, 0);
> mbuf = DPAA_PER_LCORE_DQRR_MBUF(i);
> *dpaa_seqn(mbuf) = DPAA_INVALID_MBUF_SEQN;
> - DPAA_PER_LCORE_DQRR_HELD &= ~(1 << i);
> + DPAA_PER_LCORE_DQRR_HELD &= ~(UINT64_C(1) << i);
> DPAA_PER_LCORE_DQRR_SIZE--;
> break;
> default:
> @@ -199,11 +199,11 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[],
> /* Check if there are atomic contexts to be released */
> i = 0;
> while (DPAA_PER_LCORE_DQRR_SIZE) {
> - if (DPAA_PER_LCORE_DQRR_HELD & (1 << i)) {
> + if (DPAA_PER_LCORE_DQRR_HELD & (UINT64_C(1) << i)) {
> qman_dca_index(i, 0);
> mbuf = DPAA_PER_LCORE_DQRR_MBUF(i);
> *dpaa_seqn(mbuf) = DPAA_INVALID_MBUF_SEQN;
> - DPAA_PER_LCORE_DQRR_HELD &= ~(1 << i);
> + DPAA_PER_LCORE_DQRR_HELD &= ~(UINT64_C(1) << i);
> DPAA_PER_LCORE_DQRR_SIZE--;
> }
> i++;
> @@ -263,11 +263,11 @@ dpaa_event_dequeue_burst_intr(void *port, struct rte_event ev[],
> /* Check if there are atomic contexts to be released */
> i = 0;
> while (DPAA_PER_LCORE_DQRR_SIZE) {
> - if (DPAA_PER_LCORE_DQRR_HELD & (1 << i)) {
> + if (DPAA_PER_LCORE_DQRR_HELD & (UINT64_C(1) << i)) {
> qman_dca_index(i, 0);
> mbuf = DPAA_PER_LCORE_DQRR_MBUF(i);
> *dpaa_seqn(mbuf) = DPAA_INVALID_MBUF_SEQN;
> - DPAA_PER_LCORE_DQRR_HELD &= ~(1 << i);
> + DPAA_PER_LCORE_DQRR_HELD &= ~(UINT64_C(1) << i);
> DPAA_PER_LCORE_DQRR_SIZE--;
> }
> i++;
Acked-by: Hemant Agrawal <hemant.agrawal at nxp.com>
More information about the stable
mailing list