patch 'test/bonding: fix MAC address comparison' has been queued to stable release 22.11.7

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 22.11.7

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/29/24. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/d82f1f87600df76212a41eb4b9401ac18c7af5fb

Thanks.

Luca Boccassi

---
>From d82f1f87600df76212a41eb4b9401ac18c7af5fb Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Thu, 21 Nov 2024 10:23:23 -0800
Subject: [PATCH] test/bonding: fix MAC address comparison

[ upstream commit f7f85632daf6d6f525d443f90a0ac3c8a3e40b72 ]

The first argument of 'memcmp' function was equal to the second argument.
Therefore ASSERT would always be true.

Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: 92073ef961ee ("bond: unit tests")

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Chengwen Feng <fengchengwen at huawei.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
 app/test/test_link_bonding.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c
index f342b04802..5dfee4639b 100644
--- a/app/test/test_link_bonding.c
+++ b/app/test/test_link_bonding.c
@@ -786,7 +786,7 @@ test_set_primary_slave(void)
 		TEST_ASSERT_SUCCESS(rte_eth_macaddr_get(test_params->bonded_port_id, &read_mac_addr),
 				"Failed to get mac address (port %d)",
 				test_params->bonded_port_id);
-		TEST_ASSERT_SUCCESS(memcmp(&read_mac_addr, &read_mac_addr,
+		TEST_ASSERT_SUCCESS(memcmp(expected_mac_addr, &read_mac_addr,
 				sizeof(read_mac_addr)),
 				"bonded port mac address not set to that of primary port\n");
 
-- 
2.45.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2024-11-27 00:29:59.580661534 +0000
+++ 0002-test-bonding-fix-MAC-address-comparison.patch	2024-11-27 00:29:59.504711022 +0000
@@ -1 +1 @@
-From f7f85632daf6d6f525d443f90a0ac3c8a3e40b72 Mon Sep 17 00:00:00 2001
+From d82f1f87600df76212a41eb4b9401ac18c7af5fb Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit f7f85632daf6d6f525d443f90a0ac3c8a3e40b72 ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -21 +22 @@
-index 805613d7dd..b752a5ecbf 100644
+index f342b04802..5dfee4639b 100644
@@ -24,2 +25,2 @@
-@@ -792,7 +792,7 @@ test_set_primary_member(void)
- 				&read_mac_addr),
+@@ -786,7 +786,7 @@ test_set_primary_slave(void)
+ 		TEST_ASSERT_SUCCESS(rte_eth_macaddr_get(test_params->bonded_port_id, &read_mac_addr),
@@ -27 +28 @@
- 				test_params->bonding_port_id);
+ 				test_params->bonded_port_id);
@@ -31 +32 @@
- 				"bonding port mac address not set to that of primary port\n");
+ 				"bonded port mac address not set to that of primary port\n");