patch 'crypto/bcmfs: fix free function mismatch' has been queued to stable release 21.11.9

Kevin Traynor ktraynor at redhat.com
Wed Nov 27 18:17:16 CET 2024


Hi,

FYI, your patch has been queued to stable release 21.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/02/24. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/17d0a3e5438d1bff2d17266ff4f1111008c138cb

Thanks.

Kevin

---
>From 17d0a3e5438d1bff2d17266ff4f1111008c138cb Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Tue, 8 Oct 2024 09:47:06 -0700
Subject: [PATCH] crypto/bcmfs: fix free function mismatch
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

[ upstream commit b1703af8e77d9e872e2ead92ab2dbcf290686f78 ]

The device structure is allocated with rte_malloc() and
then incorrectly freed with free().
This will lead to corrupt malloc pool.

Bugzilla ID: 1552
Fixes: c8e79da7c676 ("crypto/bcmfs: introduce BCMFS driver")

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
Acked-by: Morten Brørup <mb at smartsharesystems.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev at huawei.com>
Acked-by: Wathsala Vithanage <wathsala.vithanage at arm.com>
---
 drivers/crypto/bcmfs/bcmfs_device.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/bcmfs/bcmfs_device.c b/drivers/crypto/bcmfs/bcmfs_device.c
index 27720e4eb8..0d43a9bad0 100644
--- a/drivers/crypto/bcmfs/bcmfs_device.c
+++ b/drivers/crypto/bcmfs/bcmfs_device.c
@@ -139,5 +139,5 @@ fsdev_allocate_one_dev(struct rte_vdev_device *vdev,
 
 cleanup:
-	free(fsdev);
+	rte_free(fsdev);
 
 	return NULL;
@@ -163,5 +163,5 @@ fsdev_release(struct bcmfs_device *fsdev)
 
 	TAILQ_REMOVE(&fsdev_list, fsdev, next);
-	free(fsdev);
+	rte_free(fsdev);
 }
 
-- 
2.47.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2024-11-27 17:17:38.623181519 +0000
+++ 0009-crypto-bcmfs-fix-free-function-mismatch.patch	2024-11-27 17:17:38.160269036 +0000
@@ -1 +1 @@
-From b1703af8e77d9e872e2ead92ab2dbcf290686f78 Mon Sep 17 00:00:00 2001
+From 17d0a3e5438d1bff2d17266ff4f1111008c138cb Mon Sep 17 00:00:00 2001
@@ -8,0 +9,2 @@
+[ upstream commit b1703af8e77d9e872e2ead92ab2dbcf290686f78 ]
+
@@ -15 +16,0 @@
-Cc: stable at dpdk.org
@@ -27 +28 @@
-index ada7ba342c..46522970d5 100644
+index 27720e4eb8..0d43a9bad0 100644
@@ -30 +31 @@
-@@ -140,5 +140,5 @@ fsdev_allocate_one_dev(struct rte_vdev_device *vdev,
+@@ -139,5 +139,5 @@ fsdev_allocate_one_dev(struct rte_vdev_device *vdev,
@@ -37 +38 @@
-@@ -164,5 +164,5 @@ fsdev_release(struct bcmfs_device *fsdev)
+@@ -163,5 +163,5 @@ fsdev_release(struct bcmfs_device *fsdev)



More information about the stable mailing list