patch 'net/txgbe: fix driver load bit to inform firmware' has been queued to stable release 21.11.9

Kevin Traynor ktraynor at redhat.com
Wed Nov 27 18:18:36 CET 2024


Hi,

FYI, your patch has been queued to stable release 21.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/02/24. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/aae3e72718580b90f4fc377d5e5c0ce4d71f1e2f

Thanks.

Kevin

---
>From aae3e72718580b90f4fc377d5e5c0ce4d71f1e2f Mon Sep 17 00:00:00 2001
From: Jiawen Wu <jiawenwu at trustnetic.com>
Date: Mon, 4 Nov 2024 10:29:58 +0800
Subject: [PATCH] net/txgbe: fix driver load bit to inform firmware

[ upstream commit 0a8f064bbc2cf4978857eae84e86c6b2c9e65feb ]

Drv_load bit will be reset to default 0 after hardware LAN reset,
reconfigure it to inform firmware that driver is loaded. And set it to 0
when device is closed.

Fixes: b1f596677d8e ("net/txgbe: support device start")

Signed-off-by: Jiawen Wu <jiawenwu at trustnetic.com>
---
 drivers/net/txgbe/txgbe_ethdev.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c
index 1dbf7c554e..9fc3d1df4d 100644
--- a/drivers/net/txgbe/txgbe_ethdev.c
+++ b/drivers/net/txgbe/txgbe_ethdev.c
@@ -331,4 +331,6 @@ txgbe_pf_reset_hw(struct txgbe_hw *hw)
 
 	ctrl_ext = rd32(hw, TXGBE_PORTCTL);
+	/* let hardware know driver is loaded */
+	ctrl_ext |= TXGBE_PORTCTL_DRVLOAD;
 	/* Set PF Reset Done bit so PF/VF Mail Ops can work */
 	ctrl_ext |= TXGBE_PORTCTL_RSTDONE;
@@ -2008,4 +2010,7 @@ txgbe_dev_close(struct rte_eth_dev *dev)
 	ret = txgbe_dev_stop(dev);
 
+	/* Let firmware take over control of hardware */
+	wr32m(hw, TXGBE_PORTCTL, TXGBE_PORTCTL_DRVLOAD, 0);
+
 	txgbe_dev_free_queues(dev);
 
-- 
2.47.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2024-11-27 17:17:41.061123632 +0000
+++ 0089-net-txgbe-fix-driver-load-bit-to-inform-firmware.patch	2024-11-27 17:17:38.292269720 +0000
@@ -1 +1 @@
-From 0a8f064bbc2cf4978857eae84e86c6b2c9e65feb Mon Sep 17 00:00:00 2001
+From aae3e72718580b90f4fc377d5e5c0ce4d71f1e2f Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 0a8f064bbc2cf4978857eae84e86c6b2c9e65feb ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
-index 2834468764..4aa3bfd0bc 100644
+index 1dbf7c554e..9fc3d1df4d 100644
@@ -22 +23 @@
-@@ -332,4 +332,6 @@ txgbe_pf_reset_hw(struct txgbe_hw *hw)
+@@ -331,4 +331,6 @@ txgbe_pf_reset_hw(struct txgbe_hw *hw)
@@ -29 +30 @@
-@@ -2062,4 +2064,7 @@ txgbe_dev_close(struct rte_eth_dev *dev)
+@@ -2008,4 +2010,7 @@ txgbe_dev_close(struct rte_eth_dev *dev)



More information about the stable mailing list