patch 'net/mlx5/hws: fix fragmented packet type matching' has been queued to stable release 23.11.4
Xueming Li
xuemingl at nvidia.com
Tue Apr 8 10:01:43 CEST 2025
Hi,
FYI, your patch has been queued to stable release 23.11.4
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/10/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=9cdc6c49e8edcb75146184e536fc1d8292565d7f
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From 9cdc6c49e8edcb75146184e536fc1d8292565d7f Mon Sep 17 00:00:00 2001
From: Alexander Kozyrev <akozyrev at nvidia.com>
Date: Thu, 19 Dec 2024 18:05:49 +0200
Subject: [PATCH] net/mlx5/hws: fix fragmented packet type matching
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit 5782bb1a5902a498176cb2fd0903d7a97be1b01a ]
Fragmented PTYPE matching requires setting the mask to the exact
RTE_PTYPE_L4_FRAG value to avoid conflicts with other L4 types.
Adding L2 or L3 types to the same mask should be allowed,
but there is a check for the exact value for setting the definer.
This prevents the fragmented packets from matching in case of L2/L3
mask is provided as well. Mask out L2/L3 types when setting L4_FRAG.
Fixes: 761439a20f82 ("net/mlx5/hws: support fragmented packet type matching")
Signed-off-by: Alexander Kozyrev <akozyrev at nvidia.com>
Acked-by: Dariusz Sosnowski <dsosnowski at nvidia.com>
---
drivers/net/mlx5/hws/mlx5dr_definer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c
index ef437a6dbd..93e15122ed 100644
--- a/drivers/net/mlx5/hws/mlx5dr_definer.c
+++ b/drivers/net/mlx5/hws/mlx5dr_definer.c
@@ -1884,7 +1884,7 @@ mlx5dr_definer_conv_item_ptype(struct mlx5dr_definer_conv_data *cd,
* Cannot be combined with Layer 4 Types (TCP/UDP).
* The exact value must be specified in the mask.
*/
- if (m->packet_type == RTE_PTYPE_L4_FRAG) {
+ if ((m->packet_type & RTE_PTYPE_L4_MASK) == RTE_PTYPE_L4_FRAG) {
fc = &cd->fc[DR_CALC_FNAME(PTYPE_FRAG, false)];
fc->item_idx = item_idx;
fc->tag_set = &mlx5dr_definer_ptype_frag_set;
@@ -1900,7 +1900,7 @@ mlx5dr_definer_conv_item_ptype(struct mlx5dr_definer_conv_data *cd,
}
if (m->packet_type & RTE_PTYPE_INNER_L4_MASK) {
- if (m->packet_type == RTE_PTYPE_INNER_L4_FRAG) {
+ if ((m->packet_type & RTE_PTYPE_INNER_L4_MASK) == RTE_PTYPE_INNER_L4_FRAG) {
fc = &cd->fc[DR_CALC_FNAME(PTYPE_FRAG, true)];
fc->item_idx = item_idx;
fc->tag_set = &mlx5dr_definer_ptype_frag_set;
--
2.34.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-04-08 15:39:06.561060976 +0800
+++ 0019-net-mlx5-hws-fix-fragmented-packet-type-matching.patch 2025-04-08 15:39:05.916436584 +0800
@@ -1 +1 @@
-From 5782bb1a5902a498176cb2fd0903d7a97be1b01a Mon Sep 17 00:00:00 2001
+From 9cdc6c49e8edcb75146184e536fc1d8292565d7f Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 5782bb1a5902a498176cb2fd0903d7a97be1b01a ]
@@ -14 +16,0 @@
-Cc: stable at dpdk.org
@@ -23 +25 @@
-index e6d3dbfa46..837e0c47bd 100644
+index ef437a6dbd..93e15122ed 100644
@@ -26 +28 @@
-@@ -2205,7 +2205,7 @@ mlx5dr_definer_conv_item_ptype(struct mlx5dr_definer_conv_data *cd,
+@@ -1884,7 +1884,7 @@ mlx5dr_definer_conv_item_ptype(struct mlx5dr_definer_conv_data *cd,
@@ -35 +37 @@
-@@ -2227,7 +2227,7 @@ mlx5dr_definer_conv_item_ptype(struct mlx5dr_definer_conv_data *cd,
+@@ -1900,7 +1900,7 @@ mlx5dr_definer_conv_item_ptype(struct mlx5dr_definer_conv_data *cd,
More information about the stable
mailing list