patch 'test/crypto: fix AES-ECB test lengths' has been queued to stable release 23.11.4
Xueming Li
xuemingl at nvidia.com
Tue Apr 8 10:01:48 CEST 2025
Hi,
FYI, your patch has been queued to stable release 23.11.4
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/10/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=6302c7969908210cbc261eabfde781aa29bc71bd
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From 6302c7969908210cbc261eabfde781aa29bc71bd Mon Sep 17 00:00:00 2001
From: Shaokai Zhang <felix.zhang at jaguarmicro.com>
Date: Thu, 16 Jan 2025 16:35:48 +0800
Subject: [PATCH] test/crypto: fix AES-ECB test lengths
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit 4d6b2633b030f6b469c78fd00f012c8192979332 ]
The test vector aes_test_data_19 plaintext is 192 bytes and this vector
is used to test 192-byte plaintext, but test vector plaintext.len
value is incorrectly assigned to 64.
The test vector aes_test_data_20 plaintext length is 256 bytes, but
testcase comment incorrectly describes it as "192-byte plaintext".
Fixes: c94c520b4163 ("crypto/aesni_mb: support AES-ECB")
Signed-off-by: Shaokai Zhang <felix.zhang at jaguarmicro.com>
Reviewed-by: Joey Xing <joey.xing at jaguarmicro.com>
Acked-by: Akhil Goyal <gakhil at marvell.com>
---
.mailmap | 1 +
app/test/test_cryptodev_aes_test_vectors.h | 6 +++---
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/.mailmap b/.mailmap
index 90b3d473b7..95d09b8ced 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1317,6 +1317,7 @@ Shally Verma <shallyv at marvell.com> <shally.verma at caviumnetworks.com>
Shani Peretz <shperetz at nvidia.com>
Shannon Nelson <snelson at pensando.io>
Shannon Zhao <zhaoshenglong at huawei.com>
+Shaokai Zhang <felix.zhang at jaguarmicro.com>
Shaopeng He <shaopeng.he at intel.com>
Shaowei Sun <1819846787 at qq.com>
Sharmila Podury <sharmila.podury at att.com>
diff --git a/app/test/test_cryptodev_aes_test_vectors.h b/app/test/test_cryptodev_aes_test_vectors.h
index 7127156cc4..505e603b7e 100644
--- a/app/test/test_cryptodev_aes_test_vectors.h
+++ b/app/test/test_cryptodev_aes_test_vectors.h
@@ -833,11 +833,11 @@ static const struct blockcipher_test_data aes_test_data_19 = {
},
.plaintext = {
.data = plaintext_aes192ecb_192bytes,
- .len = 64
+ .len = 192
},
.ciphertext = {
.data = ciphertext_aes192ecb_192bytes,
- .len = 64
+ .len = 192
}
};
@@ -5103,7 +5103,7 @@ static const struct blockcipher_test_case aes_cipheronly_test_cases[] = {
.op_mask = BLOCKCIPHER_TEST_OP_ENCRYPT,
},
{
- .test_descr = "AES-256-ECB Decryption (192-byte plaintext)",
+ .test_descr = "AES-256-ECB Decryption (256-byte plaintext)",
.test_data = &aes_test_data_20,
.op_mask = BLOCKCIPHER_TEST_OP_DECRYPT,
},
--
2.34.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-04-08 15:39:06.699525631 +0800
+++ 0024-test-crypto-fix-AES-ECB-test-lengths.patch 2025-04-08 15:39:05.936436578 +0800
@@ -1 +1 @@
-From 4d6b2633b030f6b469c78fd00f012c8192979332 Mon Sep 17 00:00:00 2001
+From 6302c7969908210cbc261eabfde781aa29bc71bd Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 4d6b2633b030f6b469c78fd00f012c8192979332 ]
@@ -14 +16,0 @@
-Cc: stable at dpdk.org
@@ -25 +27 @@
-index 3ea758ca12..b3ffe83f46 100644
+index 90b3d473b7..95d09b8ced 100644
@@ -28 +30 @@
-@@ -1396,6 +1396,7 @@ Shally Verma <shallyv at marvell.com> <shally.verma at caviumnetworks.com>
+@@ -1317,6 +1317,7 @@ Shally Verma <shallyv at marvell.com> <shally.verma at caviumnetworks.com>
More information about the stable
mailing list