patch 'pdump: clear statistics when enabled' has been queued to stable release 23.11.4

[Xueming Li]

Hi,

FYI, your patch has been queued to stable release 23.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/10/25. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=7390205d1311798606e02388b012620706293d5b

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 7390205d1311798606e02388b012620706293d5b Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Thu, 19 Dec 2024 15:58:53 -0800
Subject: [PATCH] pdump: clear statistics when enabled
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit b8392fa204ed46b580d61e7621948f1b187c9f98 ]

The pdump statistics are used to keep track of the number
of packets captured, filtered, etc. These need not be cumalative
and instead should be start counting when capture starts.

This fixes the issue where multiple invocations of dumpcap
would include counts from previous invocations.

Bugzilla ID: 1604
Fixes: 10f726efe26c ("pdump: support pcapng and filtering")

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
Acked-by: Vladimir Medvedkin <vladimir.medvedkin at intel.com>
---
 lib/pdump/rte_pdump.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c
index 5a1ec14d7a..56e1a8d598 100644
--- a/lib/pdump/rte_pdump.c
+++ b/lib/pdump/rte_pdump.c
@@ -200,6 +200,8 @@ pdump_register_rx_callbacks(enum pdump_version ver,
 					rte_errno);
 				return rte_errno;
 			}
+
+			memset(&pdump_stats->rx[port][qid], 0, sizeof(struct rte_pdump_stats));
 		} else if (operation == DISABLE) {
 			int ret;
 
@@ -258,6 +260,7 @@ pdump_register_tx_callbacks(enum pdump_version ver,
 					rte_errno);
 				return rte_errno;
 			}
+			memset(&pdump_stats->tx[port][qid], 0, sizeof(struct rte_pdump_stats));
 		} else if (operation == DISABLE) {
 			int ret;
 
-- 
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2025-04-08 15:39:07.182378375 +0800
+++ 0043-pdump-clear-statistics-when-enabled.patch	2025-04-08 15:39:06.046436542 +0800
@@ -1 +1 @@
-From b8392fa204ed46b580d61e7621948f1b187c9f98 Mon Sep 17 00:00:00 2001
+From 7390205d1311798606e02388b012620706293d5b Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit b8392fa204ed46b580d61e7621948f1b187c9f98 ]
@@ -15 +17,0 @@
-Cc: stable at dpdk.org
@@ -25 +27 @@
-index 679c3dd0b5..0e6ffc167b 100644
+index 5a1ec14d7a..56e1a8d598 100644
@@ -28 +30 @@
-@@ -199,6 +199,8 @@ pdump_register_rx_callbacks(enum pdump_version ver,
+@@ -200,6 +200,8 @@ pdump_register_rx_callbacks(enum pdump_version ver,
@@ -37 +39 @@
-@@ -257,6 +259,7 @@ pdump_register_tx_callbacks(enum pdump_version ver,
+@@ -258,6 +260,7 @@ pdump_register_tx_callbacks(enum pdump_version ver,