patch 'app/procinfo: fix const pointer in collectd format' has been queued to stable release 22.11.11

luca.boccassi at gmail.com luca.boccassi at gmail.com
Mon Dec 1 12:51:33 CET 2025


Hi,

FYI, your patch has been queued to stable release 22.11.11

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/03/25. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/2f20b57940cfa07960247de7e5c32d2af346d60a

Thanks.

Luca Boccassi

---
>From 2f20b57940cfa07960247de7e5c32d2af346d60a Mon Sep 17 00:00:00 2001
From: David Marchand <david.marchand at redhat.com>
Date: Fri, 28 Nov 2025 14:56:15 +0100
Subject: [PATCH] app/procinfo: fix const pointer in collectd format

[ upstream commit 11a64ff198cf3d380c00f08d3895cd06dcd90d44 ]

With latest glibc (Fedora Rawhide):
../app/proc-info/main.c: In function 'collectd_resolve_cnt_type':
../app/proc-info/main.c:689:26: warning: initialization discards
	'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  689 |         char *type_end = strrchr(cnt_name, '_');
      |                          ^~~~~~~

Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id")

Signed-off-by: David Marchand <david.marchand at redhat.com>
Reviewed-by: Chengwen Feng <fengchengwen at huawei.com>
---
 app/proc-info/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index 8fd7ac945c..dc0749ca6e 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -501,7 +501,7 @@ nic_stats_clear(uint16_t port_id)
 
 static void collectd_resolve_cnt_type(char *cnt_type, size_t cnt_type_len,
 				      const char *cnt_name) {
-	char *type_end = strrchr(cnt_name, '_');
+	const char *type_end = strrchr(cnt_name, '_');
 
 	if ((type_end != NULL) &&
 	    (strncmp(cnt_name, "rx_", strlen("rx_")) == 0)) {
-- 
2.47.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2025-12-01 11:51:15.501590275 +0000
+++ 0008-app-procinfo-fix-const-pointer-in-collectd-format.patch	2025-12-01 11:51:15.219263610 +0000
@@ -1 +1 @@
-From 11a64ff198cf3d380c00f08d3895cd06dcd90d44 Mon Sep 17 00:00:00 2001
+From 2f20b57940cfa07960247de7e5c32d2af346d60a Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 11a64ff198cf3d380c00f08d3895cd06dcd90d44 ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -23 +24 @@
-index b09c03ab35..5925bbb765 100644
+index 8fd7ac945c..dc0749ca6e 100644
@@ -26 +27 @@
-@@ -686,7 +686,7 @@ nic_stats_clear(uint16_t port_id)
+@@ -501,7 +501,7 @@ nic_stats_clear(uint16_t port_id)


More information about the stable mailing list