patch 'net/ixgbe/base: fix TSAM checking return value' has been queued to stable release 24.11.2
Kevin Traynor
ktraynor at redhat.com
Thu Feb 13 10:57:51 CET 2025
Hi,
FYI, your patch has been queued to stable release 24.11.2
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/17/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/194e3b363dbe1cd002bb5b5bb5535999bfcf6d73
Thanks.
Kevin
---
>From 194e3b363dbe1cd002bb5b5bb5535999bfcf6d73 Mon Sep 17 00:00:00 2001
From: Lukasz Krakowiak <lukaszx.krakowiak at intel.com>
Date: Tue, 14 Jan 2025 18:10:11 +0800
Subject: [PATCH] net/ixgbe/base: fix TSAM checking return value
[ upstream commit 0699ce484da324b60572a906cf7d013394f074e2 ]
The error return value of ixgbe_get_fw_tsam_mode function,
(IXGBE_NOT_IMPLEMENTED) is be a large integer that does not match the
desired bool type. Rework to return false on error instead.
Fixes: 316637762a5f ("net/ixgbe/base: enable E610 device")
Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak at intel.com>
Signed-off-by: Yuan Wang <yuanx.wang at intel.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
drivers/net/ixgbe/base/ixgbe_api.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/base/ixgbe_api.c b/drivers/net/ixgbe/base/ixgbe_api.c
index b4920867bc..ffff670dd3 100644
--- a/drivers/net/ixgbe/base/ixgbe_api.c
+++ b/drivers/net/ixgbe/base/ixgbe_api.c
@@ -1169,6 +1169,7 @@ s32 ixgbe_set_fw_drv_ver(struct ixgbe_hw *hw, u8 maj, u8 min, u8 build,
bool ixgbe_get_fw_tsam_mode(struct ixgbe_hw *hw)
{
- return ixgbe_call_func(hw, hw->mac.ops.get_fw_tsam_mode, (hw),
- IXGBE_NOT_IMPLEMENTED);
+ if (hw->mac.ops.get_fw_tsam_mode)
+ return hw->mac.ops.get_fw_tsam_mode(hw);
+ return false;
}
--
2.48.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-02-12 17:29:37.205232776 +0000
+++ 0024-net-ixgbe-base-fix-TSAM-checking-return-value.patch 2025-02-12 17:29:34.265945422 +0000
@@ -1 +1 @@
-From 0699ce484da324b60572a906cf7d013394f074e2 Mon Sep 17 00:00:00 2001
+From 194e3b363dbe1cd002bb5b5bb5535999bfcf6d73 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 0699ce484da324b60572a906cf7d013394f074e2 ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
More information about the stable
mailing list