patch 'net/ixgbe/base: add missing buffer copy for ACI' has been queued to stable release 24.11.2

[Kevin Traynor]

Hi,

FYI, your patch has been queued to stable release 24.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/17/25. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/00ef3d8f8fd1d6ce46177087d7ffb81f4e3447c6

Thanks.

Kevin

---
>From 00ef3d8f8fd1d6ce46177087d7ffb81f4e3447c6 Mon Sep 17 00:00:00 2001
From: Dan Nowlin <dan.nowlin at intel.com>
Date: Tue, 14 Jan 2025 18:10:19 +0800
Subject: [PATCH] net/ixgbe/base: add missing buffer copy for ACI

[ upstream commit 37239792b0d67fedc011db54ffa32b022a391787 ]

Add missing buffer copy in ixgbe_aci_send_cmd().

In ixgbe_aci_send_cmd() there is code to retry aq commands for
certain commands. To achieve this the function makes a copy of the
original ixgbe_aci_desc structure and allocates memory to store an
original copy of the command buffer. This allows the original structure
and buffer to be restored before attempting the command again. However,
the function didn't perform the actual copy of the original command
buffer into the copy buffer.

Fixes: 25b48e569f2f ("net/ixgbe/base: add E610 Admin Command Interface")

Signed-off-by: Dan Nowlin <dan.nowlin at intel.com>
Signed-off-by: Yuan Wang <yuanx.wang at intel.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
 drivers/net/ixgbe/base/ixgbe_e610.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ixgbe/base/ixgbe_e610.c b/drivers/net/ixgbe/base/ixgbe_e610.c
index 31c2d986aa..1967519be0 100644
--- a/drivers/net/ixgbe/base/ixgbe_e610.c
+++ b/drivers/net/ixgbe/base/ixgbe_e610.c
@@ -283,4 +283,5 @@ s32 ixgbe_aci_send_cmd(struct ixgbe_hw *hw, struct ixgbe_aci_desc *desc,
 			if (!buf_cpy)
 				return IXGBE_ERR_OUT_OF_MEM;
+			memcpy(buf_cpy, buf, buf_size);
 		}
 		memcpy(&desc_cpy, desc, sizeof(desc_cpy));
-- 
2.48.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2025-02-12 17:29:37.523609485 +0000
+++ 0027-net-ixgbe-base-add-missing-buffer-copy-for-ACI.patch	2025-02-12 17:29:34.282945524 +0000
@@ -1 +1 @@
-From 37239792b0d67fedc011db54ffa32b022a391787 Mon Sep 17 00:00:00 2001
+From 00ef3d8f8fd1d6ce46177087d7ffb81f4e3447c6 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 37239792b0d67fedc011db54ffa32b022a391787 ]
+
@@ -17 +18,0 @@
-Cc: stable at dpdk.org
@@ -27 +28 @@
-index dc4eafaa5a..5474c3012a 100644
+index 31c2d986aa..1967519be0 100644