patch 'service: fix getting service lcore attributes' has been queued to stable release 24.11.2

Kevin Traynor ktraynor at redhat.com
Thu Feb 13 10:58:16 CET 2025


Hi,

FYI, your patch has been queued to stable release 24.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/17/25. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/9191c6d2c7133d016194bc72f52f8b51aed440ec

Thanks.

Kevin

---
>From 9191c6d2c7133d016194bc72f52f8b51aed440ec Mon Sep 17 00:00:00 2001
From: Piotr Krzewinski <piotr.krzewinski at ericsson.com>
Date: Fri, 20 Dec 2024 15:29:38 +0100
Subject: [PATCH] service: fix getting service lcore attributes
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

[ upstream commit 1ecb19eb4f44f984f15068834ef0c530f24ae697 ]

Perf test service_perf_autotest was failing after introduction
of lcore variables.
Fixed getting of idle_ and error_ service call statistics.

Fixes: b24bbaedbba2 ("service: keep per-lcore state in lcore variable")

Signed-off-by: Piotr Krzewinski <piotr.krzewinski at ericsson.com>
Acked-by: Harry van Haaren <harry.van.haaren at intel.com>
Reviewed-by: Mattias Rönnblom <mattias.ronnblom at ericsson.com>
---
 .mailmap                     | 1 +
 lib/eal/common/rte_service.c | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/.mailmap b/.mailmap
index 7d9b19d51f..56550db0f8 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1201,4 +1201,5 @@ Piotr Bartosiewicz <piotr.bartosiewicz at atendesoftware.pl>
 Piotr Bronowski <piotrx.bronowski at intel.com>
 Piotr Gardocki <piotrx.gardocki at intel.com>
+Piotr Krzewinski <piotr.krzewinski at ericsson.com>
 Piotr Kubaj <pkubaj at freebsd.org>
 Piotr Kwapulinski <piotr.kwapulinski at intel.com>
diff --git a/lib/eal/common/rte_service.c b/lib/eal/common/rte_service.c
index dad3150df9..1821746337 100644
--- a/lib/eal/common/rte_service.c
+++ b/lib/eal/common/rte_service.c
@@ -880,5 +880,5 @@ static uint64_t
 lcore_attr_get_service_idle_calls(uint32_t service_id, unsigned int lcore)
 {
-	struct core_state *cs = &lcore_states[lcore];
+	struct core_state *cs =	RTE_LCORE_VAR_LCORE(lcore, lcore_states);
 
 	return rte_atomic_load_explicit(&cs->service_stats[service_id].idle_calls,
@@ -889,5 +889,5 @@ static uint64_t
 lcore_attr_get_service_error_calls(uint32_t service_id, unsigned int lcore)
 {
-	struct core_state *cs = &lcore_states[lcore];
+	struct core_state *cs =	RTE_LCORE_VAR_LCORE(lcore, lcore_states);
 
 	return rte_atomic_load_explicit(&cs->service_stats[service_id].error_calls,
-- 
2.48.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2025-02-12 17:29:39.785050645 +0000
+++ 0049-service-fix-getting-service-lcore-attributes.patch	2025-02-12 17:29:34.351945936 +0000
@@ -1 +1 @@
-From 1ecb19eb4f44f984f15068834ef0c530f24ae697 Mon Sep 17 00:00:00 2001
+From 9191c6d2c7133d016194bc72f52f8b51aed440ec Mon Sep 17 00:00:00 2001
@@ -8,0 +9,2 @@
+[ upstream commit 1ecb19eb4f44f984f15068834ef0c530f24ae697 ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -25 +26 @@
-index 19bbdbc0c8..df68fc7d34 100644
+index 7d9b19d51f..56550db0f8 100644
@@ -28 +29 @@
-@@ -1203,4 +1203,5 @@ Piotr Bartosiewicz <piotr.bartosiewicz at atendesoftware.pl>
+@@ -1201,4 +1201,5 @@ Piotr Bartosiewicz <piotr.bartosiewicz at atendesoftware.pl>



More information about the stable mailing list