patch 'dts: fix MTU set command' has been queued to stable release 24.11.2
Kevin Traynor
ktraynor at redhat.com
Thu Feb 13 10:58:19 CET 2025
Hi,
FYI, your patch has been queued to stable release 24.11.2
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/17/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/79dd2b794e9f97e1e8a1d6e5825056450f35d00b
Thanks.
Kevin
---
>From 79dd2b794e9f97e1e8a1d6e5825056450f35d00b Mon Sep 17 00:00:00 2001
From: Luca Vizzarro <luca.vizzarro at arm.com>
Date: Tue, 7 Jan 2025 13:55:30 +0000
Subject: [PATCH] dts: fix MTU set command
[ upstream commit 0882424ffc9989df9804d62cef7f58f97bde3f67 ]
There are some PMDs that in order to set a scatter-offload-compatible
MTU size, they need to have started at least once since the startup of
testpmd. This fixes the behaviour of the command to start and stop the
ports before changing the MTU to ensure this happened
Fixes: 9910db35962b ("dts: add MTU config methods to testpmd shell")
Signed-off-by: Luca Vizzarro <luca.vizzarro at arm.com>
---
dts/framework/remote_session/testpmd_shell.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py
index d187eaea94..c01ee74b21 100644
--- a/dts/framework/remote_session/testpmd_shell.py
+++ b/dts/framework/remote_session/testpmd_shell.py
@@ -1837,4 +1837,5 @@ class TestPmdShell(DPDKShell):
)
+ @requires_started_ports
@requires_stopped_ports
def set_port_mtu(self, port_id: int, mtu: int, verify: bool = True) -> None:
@@ -1843,5 +1844,7 @@ class TestPmdShell(DPDKShell):
Some PMDs require that the port be stopped before changing the MTU, and it does no harm to
stop the port before configuring in cases where it isn't required, so ports are stopped
- prior to changing their MTU.
+ prior to changing their MTU. On the other hand, some PMDs require that the port had already
+ been started once since testpmd startup. Therefore, ports are also started before stopping
+ them to ensure this has happened.
Args:
--
2.48.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-02-12 17:29:40.089205424 +0000
+++ 0052-dts-fix-MTU-set-command.patch 2025-02-12 17:29:34.356945965 +0000
@@ -1 +1 @@
-From 0882424ffc9989df9804d62cef7f58f97bde3f67 Mon Sep 17 00:00:00 2001
+From 79dd2b794e9f97e1e8a1d6e5825056450f35d00b Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 0882424ffc9989df9804d62cef7f58f97bde3f67 ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
More information about the stable
mailing list