patch 'net/bnxt: address uninitialized variables' has been queued to stable release 24.11.2
Kevin Traynor
ktraynor at redhat.com
Thu Feb 13 10:58:37 CET 2025
Hi,
FYI, your patch has been queued to stable release 24.11.2
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/17/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/0459266ffcac228396ea2e8864bde3bb68478336
Thanks.
Kevin
---
>From 0459266ffcac228396ea2e8864bde3bb68478336 Mon Sep 17 00:00:00 2001
From: Peter Spreadborough <peter.spreadborough at broadcom.com>
Date: Mon, 2 Dec 2024 16:12:08 -0500
Subject: [PATCH] net/bnxt: address uninitialized variables
[ upstream commit 7ef8b9a8a16bcc3574d4c69a29ee2039e3778045 ]
This change addresses the CID 449065: Uninitialized variables (UNINIT)
issues reported by coverity.
Coverity issue: 449065
Fixes: 80317ff6adfd ("net/bnxt/tf_core: support Thor2")
Fixes: 0513f0af034d ("net/bnxt/tf_ulp: add stats cache for Thor2")
Signed-off-by: Peter Spreadborough <peter.spreadborough at broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
---
drivers/net/bnxt/tf_core/v3/tfc_em.c | 1 +
drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/net/bnxt/tf_core/v3/tfc_em.c b/drivers/net/bnxt/tf_core/v3/tfc_em.c
index a70e35b6b1..d460ff2ee0 100644
--- a/drivers/net/bnxt/tf_core/v3/tfc_em.c
+++ b/drivers/net/bnxt/tf_core/v3/tfc_em.c
@@ -561,4 +561,5 @@ int tfc_em_delete_raw(struct tfc *tfcp,
mpc_msg_out.msg_data = &rx_msg[TFC_MPC_HEADER_SIZE_BYTES];
mpc_msg_out.msg_size = TFC_MPC_MAX_RX_BYTES;
+ mpc_msg_out.chnl_id = 0;
rc = tfc_mpc_send(tfcp->bp,
diff --git a/drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c b/drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c
index 5fa8e240db..57cbaaf09c 100644
--- a/drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c
+++ b/drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c
@@ -225,4 +225,5 @@ static uint32_t ulp_stats_cache_main_loop(void *arg)
break;
+ batch_info.enabled = false;
rc = tfc_mpc_batch_start(&batch_info);
if (unlikely(rc)) {
--
2.48.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-02-12 17:29:41.975470566 +0000
+++ 0070-net-bnxt-address-uninitialized-variables.patch 2025-02-12 17:29:34.415946318 +0000
@@ -1 +1 @@
-From 7ef8b9a8a16bcc3574d4c69a29ee2039e3778045 Mon Sep 17 00:00:00 2001
+From 0459266ffcac228396ea2e8864bde3bb68478336 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 7ef8b9a8a16bcc3574d4c69a29ee2039e3778045 ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -32 +33 @@
-index 85b72f328c..753c19b055 100644
+index 5fa8e240db..57cbaaf09c 100644
@@ -35 +36 @@
-@@ -223,4 +223,5 @@ static uint32_t ulp_stats_cache_main_loop(void *arg)
+@@ -225,4 +225,5 @@ static uint32_t ulp_stats_cache_main_loop(void *arg)
More information about the stable
mailing list