patch 'net/sfc: remove unnecessary assignment' has been queued to stable release 22.11.8
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Mon Feb 17 18:03:44 CET 2025
Hi,
FYI, your patch has been queued to stable release 22.11.8
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/19/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/ff415bac32c84488567e15997421a7736a271f32
Thanks.
Luca Boccassi
---
>From ff415bac32c84488567e15997421a7736a271f32 Mon Sep 17 00:00:00 2001
From: Ariel Otilibili <otilibil at eurecom.fr>
Date: Wed, 15 Jan 2025 13:11:51 +0100
Subject: [PATCH] net/sfc: remove unnecessary assignment
[ upstream commit de87641d5c004ef505d58d542a66d66f6a1cb2be ]
The same field was being set twice.
Coverity issue: 384444
Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure")
Signed-off-by: Ariel Otilibili <otilibil at eurecom.fr>
---
drivers/net/sfc/sfc_repr.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/sfc/sfc_repr.c b/drivers/net/sfc/sfc_repr.c
index 79025e9052..4234d63144 100644
--- a/drivers/net/sfc/sfc_repr.c
+++ b/drivers/net/sfc/sfc_repr.c
@@ -797,11 +797,7 @@ static void
sfc_repr_close(struct sfc_repr *sr)
{
SFC_ASSERT(sfc_repr_lock_is_locked(sr));
-
SFC_ASSERT(sr->state == SFC_ETHDEV_CONFIGURED);
- sr->state = SFC_ETHDEV_CLOSING;
-
- /* Put representor close actions here */
sr->state = SFC_ETHDEV_INITIALIZED;
}
--
2.47.2
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-02-17 16:13:17.282207920 +0000
+++ 0011-net-sfc-remove-unnecessary-assignment.patch 2025-02-17 16:13:16.794441593 +0000
@@ -1 +1 @@
-From de87641d5c004ef505d58d542a66d66f6a1cb2be Mon Sep 17 00:00:00 2001
+From ff415bac32c84488567e15997421a7736a271f32 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit de87641d5c004ef505d58d542a66d66f6a1cb2be ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -18 +19 @@
-index c2e5d4eb9e..2c1421b959 100644
+index 79025e9052..4234d63144 100644
@@ -21 +22 @@
-@@ -769,11 +769,7 @@ static void
+@@ -797,11 +797,7 @@ static void
More information about the stable
mailing list