patch 'common/cnxk: fix atomic load in batch ops' has been queued to stable release 22.11.8
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Mon Feb 17 18:03:48 CET 2025
Hi,
FYI, your patch has been queued to stable release 22.11.8
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/19/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/0872aaa1f0c0d4a849f857367ae1c0f59eddaf1f
Thanks.
Luca Boccassi
---
>From 0872aaa1f0c0d4a849f857367ae1c0f59eddaf1f Mon Sep 17 00:00:00 2001
From: Nawal Kishor <nkishor at marvell.com>
Date: Mon, 2 Dec 2024 22:27:39 +0530
Subject: [PATCH] common/cnxk: fix atomic load in batch ops
[ upstream commit 73d38682fddd614d95942442c20b3a1de211bb4c ]
In roc batch alloc wait code, __ATOMIC_RELAXED is changed to
__ATOMIC_ACQUIRE in order to avoid potential out of order loads.
Fixes: 50d08d3934ec ("common/cnxk: fix batch alloc completion poll logic")
Signed-off-by: Nawal Kishor <nkishor at marvell.com>
---
.mailmap | 1 +
drivers/common/cnxk/roc_npa.h | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/.mailmap b/.mailmap
index 51c2bc9df3..8eb97ded9f 100644
--- a/.mailmap
+++ b/.mailmap
@@ -986,6 +986,7 @@ Natalie Samsonov <nsamsono at marvell.com>
Natanael Copa <ncopa at alpinelinux.org>
Nathan Law <nlaw at brocade.com>
Nathan Skrzypczak <nathan.skrzypczak at gmail.com>
+Nawal Kishor <nkishor at marvell.com>
Neel Patel <neel.patel at amd.com> <neel at pensando.io>
Neil Horman <nhorman at tuxdriver.com>
Nelio Laranjeiro <nelio.laranjeiro at 6wind.com>
diff --git a/drivers/common/cnxk/roc_npa.h b/drivers/common/cnxk/roc_npa.h
index 46b668a310..3d0821dfe6 100644
--- a/drivers/common/cnxk/roc_npa.h
+++ b/drivers/common/cnxk/roc_npa.h
@@ -261,7 +261,7 @@ roc_npa_batch_alloc_wait(uint64_t *cache_line, unsigned int wait_us)
/* Batch alloc status code is updated in bits [5:6] of the first word
* of the 128 byte cache line.
*/
- while (((__atomic_load_n(cache_line, __ATOMIC_RELAXED) >> 5) & 0x3) ==
+ while (((__atomic_load_n(cache_line, __ATOMIC_ACQUIRE) >> 5) & 0x3) ==
ALLOC_CCODE_INVAL)
if (wait_us && (plt_tsc_cycles() - start) >= ticks)
break;
--
2.47.2
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-02-17 16:13:17.420757215 +0000
+++ 0015-common-cnxk-fix-atomic-load-in-batch-ops.patch 2025-02-17 16:13:16.798441593 +0000
@@ -1 +1 @@
-From 73d38682fddd614d95942442c20b3a1de211bb4c Mon Sep 17 00:00:00 2001
+From 0872aaa1f0c0d4a849f857367ae1c0f59eddaf1f Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 73d38682fddd614d95942442c20b3a1de211bb4c ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
-index 1ed47e1cad..8524952d24 100644
+index 51c2bc9df3..8eb97ded9f 100644
@@ -22,2 +23,2 @@
-@@ -1079,6 +1079,7 @@ Natanael Copa <ncopa at alpinelinux.org>
- Nathan Brown <nathan.brown at arm.com>
+@@ -986,6 +986,7 @@ Natalie Samsonov <nsamsono at marvell.com>
+ Natanael Copa <ncopa at alpinelinux.org>
@@ -31 +32 @@
-index f7cb4460e7..8525038810 100644
+index 46b668a310..3d0821dfe6 100644
@@ -34 +35 @@
-@@ -255,7 +255,7 @@ roc_npa_batch_alloc_wait(uint64_t *cache_line, unsigned int wait_us)
+@@ -261,7 +261,7 @@ roc_npa_batch_alloc_wait(uint64_t *cache_line, unsigned int wait_us)
More information about the stable
mailing list