patch 'use Python raw string notation' has been queued to stable release 22.11.8
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Mon Feb 17 18:03:56 CET 2025
Hi,
FYI, your patch has been queued to stable release 22.11.8
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/19/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/36f4323ab38a21028cb1d41c253f815031ef4915
Thanks.
Luca Boccassi
---
>From 36f4323ab38a21028cb1d41c253f815031ef4915 Mon Sep 17 00:00:00 2001
From: Ariel Otilibili <otilibil at eurecom.fr>
Date: Sat, 14 Dec 2024 11:36:35 +0100
Subject: [PATCH] use Python raw string notation
[ upstream commit d3e90e5e37872f1040f37a08b056102c1a302bb3 ]
* follow up of a discussion with Robin Jarry
* since 3.12 invalid escape sequences generate SyntaxWarning
* in the future, these invalid sequences will generate SyntaxError
* therefore changed syntax to raw string notation.
Link: https://inbox.dpdk.org/dev/D6AMQXRSG8E7.33BAORRHRHV9A@redhat.com/
Link: https://docs.python.org/3/whatsnew/3.12.html#other-language-changes
Fixes: 9d4efc5cc6f9 ("buildtools: fix NUMA nodes count")
Fixes: f88b0b892204 ("devtools: forbid indent with tabs in Meson")
Suggested-by: Robin Jarry <rjarry at redhat.com>
Signed-off-by: Ariel Otilibili <otilibil at eurecom.fr>
Reviewed-by: Luca Vizzarro <luca.vizzarro at arm.com>
---
buildtools/get-numa-count.py | 2 +-
devtools/check-meson.py | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/buildtools/get-numa-count.py b/buildtools/get-numa-count.py
index 2f243886cd..f8bea5b58e 100644
--- a/buildtools/get-numa-count.py
+++ b/buildtools/get-numa-count.py
@@ -11,7 +11,7 @@ import re
if os.name == 'posix':
if os.path.isdir('/sys/devices/system/node'):
numa_nodes = glob.glob('/sys/devices/system/node/node*')
- numa_nodes.sort(key=lambda l: int(re.findall('\d+', l)[0]))
+ numa_nodes.sort(key=lambda l: int(re.findall(r'\d+', l)[0]))
print(int(os.path.basename(numa_nodes[-1])[4:]) + 1)
else:
subprocess.run(['sysctl', '-n', 'vm.ndomains'], check=False)
diff --git a/devtools/check-meson.py b/devtools/check-meson.py
index 4b2338828d..9a33d8b036 100755
--- a/devtools/check-meson.py
+++ b/devtools/check-meson.py
@@ -51,7 +51,7 @@ def check_indentation(filename, contents):
code, comments = split_code_comments(line)
if not code.strip():
continue
- if re.match('^ *\t', code):
+ if re.match(r'^ *\t', code):
print(f'Error parsing {filename}:{lineno}, got some tabulation')
if code.endswith('files('):
if infiles:
--
2.47.2
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-02-17 16:13:17.684389318 +0000
+++ 0023-use-Python-raw-string-notation.patch 2025-02-17 16:13:16.806441593 +0000
@@ -1 +1 @@
-From d3e90e5e37872f1040f37a08b056102c1a302bb3 Mon Sep 17 00:00:00 2001
+From 36f4323ab38a21028cb1d41c253f815031ef4915 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit d3e90e5e37872f1040f37a08b056102c1a302bb3 ]
+
@@ -15 +16,0 @@
-Cc: stable at dpdk.org
@@ -21,5 +22,3 @@
- buildtools/get-numa-count.py | 2 +-
- devtools/check-meson.py | 2 +-
- dts/framework/testbed_model/traffic_generator/scapy.py | 2 +-
- dts/tests/TestSuite_smoke_tests.py | 2 +-
- 4 files changed, 4 insertions(+), 4 deletions(-)
+ buildtools/get-numa-count.py | 2 +-
+ devtools/check-meson.py | 2 +-
+ 2 files changed, 2 insertions(+), 2 deletions(-)
@@ -53,25 +51,0 @@
-diff --git a/dts/framework/testbed_model/traffic_generator/scapy.py b/dts/framework/testbed_model/traffic_generator/scapy.py
-index d24efc44e6..a16cdf6758 100644
---- a/dts/framework/testbed_model/traffic_generator/scapy.py
-+++ b/dts/framework/testbed_model/traffic_generator/scapy.py
-@@ -237,6 +237,6 @@ class ScapyTrafficGenerator(PythonShell, CapturingTrafficGenerator):
- )
- # In the string of bytes "b'XXXX'", we only want the contents ("XXXX")
- list_of_packets_base64 = re.findall(
-- f"^b'({REGEX_FOR_BASE64_ENCODING})'", packet_strs, re.MULTILINE
-+ rf"^b'({REGEX_FOR_BASE64_ENCODING})'", packet_strs, re.MULTILINE
- )
- return [Ether(base64_bytes(pakt)) for pakt in list_of_packets_base64]
-diff --git a/dts/tests/TestSuite_smoke_tests.py b/dts/tests/TestSuite_smoke_tests.py
-index bc3a2a6bf9..ab5ad44850 100644
---- a/dts/tests/TestSuite_smoke_tests.py
-+++ b/dts/tests/TestSuite_smoke_tests.py
-@@ -136,7 +136,7 @@ class TestSmokeTests(TestSuite):
- # with the address for the nic we are on in the loop and then captures the
- # name of the driver in a group
- devbind_info_for_nic = re.search(
-- f"{nic.pci}[^\\n]*drv=([\\d\\w-]*) [^\\n]*",
-+ rf"{nic.pci}[^\\n]*drv=([\\d\\w-]*) [^\\n]*",
- all_nics_in_dpdk_devbind,
- )
- self.verify(
More information about the stable
mailing list