patch 'net/mlx5: fix Netlink socket leak' has been queued to stable release 22.11.8

luca.boccassi at gmail.com luca.boccassi at gmail.com
Mon Feb 17 18:04:03 CET 2025


Hi,

FYI, your patch has been queued to stable release 22.11.8

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/19/25. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/d0d15d60dab85f80f6bae6528109f9981df9cf49

Thanks.

Luca Boccassi

---
>From d0d15d60dab85f80f6bae6528109f9981df9cf49 Mon Sep 17 00:00:00 2001
From: "Minggang Li (Gavin)" <gavinl at nvidia.com>
Date: Mon, 23 Dec 2024 12:10:58 +0200
Subject: [PATCH] net/mlx5: fix Netlink socket leak

[ upstream commit 556a5f4ccd452d9281c3476b120d1306e0093e01 ]

Fixes: 72d7efe464b1 ("common/mlx5: share interrupt management")

Signed-off-by: Minggang Li (Gavin) <gavinl at nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
---
 .mailmap                         | 1 +
 drivers/net/mlx5/linux/mlx5_os.c | 5 +++++
 2 files changed, 6 insertions(+)

diff --git a/.mailmap b/.mailmap
index fdcfe1c30a..dc5cb75b71 100644
--- a/.mailmap
+++ b/.mailmap
@@ -944,6 +944,7 @@ Mike Stolarchuk <mike.stolarchuk at bigswitch.com>
 Mike Ximing Chen <mike.ximing.chen at intel.com>
 Milena Olech <milena.olech at intel.com>
 Min Cao <min.cao at intel.com>
+Minggang Li (Gavin) <gavinl at nvidia.com>
 Minghuan Lian <minghuan.lian at nxp.com>
 Mingjin Ye <mingjinx.ye at intel.com>
 Mingshan Zhang <mingshan.zhang at intel.com>
diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c
index 183b5e6a84..b59d559c4f 100644
--- a/drivers/net/mlx5/linux/mlx5_os.c
+++ b/drivers/net/mlx5/linux/mlx5_os.c
@@ -2657,10 +2657,15 @@ mlx5_os_dev_shared_handler_install(struct mlx5_dev_ctx_shared *sh)
 void
 mlx5_os_dev_shared_handler_uninstall(struct mlx5_dev_ctx_shared *sh)
 {
+	int fd;
+
 	mlx5_os_interrupt_handler_destroy(sh->intr_handle,
 					  mlx5_dev_interrupt_handler, sh);
+	fd = rte_intr_fd_get(sh->intr_handle_nl);
 	mlx5_os_interrupt_handler_destroy(sh->intr_handle_nl,
 					  mlx5_dev_interrupt_handler_nl, sh);
+	if (fd >= 0)
+		close(fd);
 #ifdef HAVE_IBV_DEVX_ASYNC
 	mlx5_os_interrupt_handler_destroy(sh->intr_handle_devx,
 					  mlx5_dev_interrupt_handler_devx, sh);
-- 
2.47.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2025-02-17 16:13:17.921035248 +0000
+++ 0030-net-mlx5-fix-Netlink-socket-leak.patch	2025-02-17 16:13:16.818441593 +0000
@@ -1 +1 @@
-From 556a5f4ccd452d9281c3476b120d1306e0093e01 Mon Sep 17 00:00:00 2001
+From d0d15d60dab85f80f6bae6528109f9981df9cf49 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 556a5f4ccd452d9281c3476b120d1306e0093e01 ]
+
@@ -7 +8,0 @@
-Cc: stable at dpdk.org
@@ -17 +18 @@
-index 4bc9721321..dc3dd9e5a2 100644
+index fdcfe1c30a..dc5cb75b71 100644
@@ -20 +21 @@
-@@ -1036,6 +1036,7 @@ Mike Stolarchuk <mike.stolarchuk at bigswitch.com>
+@@ -944,6 +944,7 @@ Mike Stolarchuk <mike.stolarchuk at bigswitch.com>
@@ -29 +30 @@
-index 996c97a6a9..169c229172 100644
+index 183b5e6a84..b59d559c4f 100644
@@ -32 +33 @@
-@@ -3070,10 +3070,15 @@ mlx5_os_dev_shared_handler_install(struct mlx5_dev_ctx_shared *sh)
+@@ -2657,10 +2657,15 @@ mlx5_os_dev_shared_handler_install(struct mlx5_dev_ctx_shared *sh)


More information about the stable mailing list