patch 'eal/x86: fix some intrinsics header include for Windows' has been queued to stable release 23.11.4
Xueming Li
xuemingl at nvidia.com
Tue Feb 18 13:34:03 CET 2025
Hi,
FYI, your patch has been queued to stable release 23.11.4
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
Please shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=0608e13c5705e5086fe6f809697a988a833ecd27
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From 0608e13c5705e5086fe6f809697a988a833ecd27 Mon Sep 17 00:00:00 2001
From: Andre Muezerie <andremue at linux.microsoft.com>
Date: Tue, 14 Jan 2025 08:21:13 -0800
Subject: [PATCH] eal/x86: fix some intrinsics header include for Windows
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit 5b856206c74bbcf19e12cafa15382a7e15b0a1b5 ]
Error reported:
../lib/net/net_crc_sse.c:49:17: error: call to undeclared function
'_mm_clmulepi64_si128'; ISO C99 and later do not support implicit
function declarations [-Wimplicit-function-declaration]
The fix is to remove the unnecessary ifdef around the inclusion of
header file immintrin.h. This header also contains functions that do
not require AVX instructions, so should not be included only when AVX
is available.
Bugzilla ID: 1595
Fixes: da826b7135a4 ("eal: introduce ymm type for AVX 256-bit")
Reported-by: Pier Damouny <pdamouny at nvidia.com>
Signed-off-by: Andre Muezerie <andremue at linux.microsoft.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
.mailmap | 2 +-
lib/eal/x86/include/rte_vect.h | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/.mailmap b/.mailmap
index 71967f7247..861d69289f 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1131,7 +1131,7 @@ Petr Houska <t-pehous at microsoft.com>
Phanendra Vukkisala <pvukkisala at marvell.com>
Phil Yang <phil.yang at arm.com>
Philip Prindeville <philipp at redfish-solutions.com>
-Pier Damouny <pdamouny at nvidia.com>
+Pier Damouny <pdamouny at nvidia.com>
Pierre Pfister <ppfister at cisco.com>
Piotr Azarewicz <piotr.azarewicz at intel.com> <piotrx.t.azarewicz at intel.com>
Piotr Bartosiewicz <piotr.bartosiewicz at atendesoftware.pl>
diff --git a/lib/eal/x86/include/rte_vect.h b/lib/eal/x86/include/rte_vect.h
index 560f9e4db3..8c1d0dd830 100644
--- a/lib/eal/x86/include/rte_vect.h
+++ b/lib/eal/x86/include/rte_vect.h
@@ -18,9 +18,7 @@
#if defined(__ICC) || defined(_WIN64)
#include <smmintrin.h> /* SSE4 */
-#if defined(__AVX__)
#include <immintrin.h>
-#endif
#else
#include <x86intrin.h>
#endif
--
2.34.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-02-18 19:39:01.035313478 +0800
+++ 0008-eal-x86-fix-some-intrinsics-header-include-for-Windo.patch 2025-02-18 19:39:00.418244084 +0800
@@ -1 +1 @@
-From 5b856206c74bbcf19e12cafa15382a7e15b0a1b5 Mon Sep 17 00:00:00 2001
+From 0608e13c5705e5086fe6f809697a988a833ecd27 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 5b856206c74bbcf19e12cafa15382a7e15b0a1b5 ]
@@ -18 +20,0 @@
-Cc: stable at dpdk.org
@@ -29 +31 @@
-index cc1ffe1ad9..94e12acbd4 100644
+index 71967f7247..861d69289f 100644
@@ -32 +34 @@
-@@ -1192,7 +1192,7 @@ Petr Houska <t-pehous at microsoft.com>
+@@ -1131,7 +1131,7 @@ Petr Houska <t-pehous at microsoft.com>
@@ -42 +44 @@
-index 5ac3ccfd82..5fdcd632ac 100644
+index 560f9e4db3..8c1d0dd830 100644
@@ -45 +47 @@
-@@ -19,9 +19,7 @@
+@@ -18,9 +18,7 @@
More information about the stable
mailing list