patch 'net/sfc: remove unnecessary assignment' has been queued to stable release 23.11.4
Xueming Li
xuemingl at nvidia.com
Tue Feb 18 13:34:09 CET 2025
Hi,
FYI, your patch has been queued to stable release 23.11.4
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
Please shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=d3699f97a72d417a9555c41792d22ee03c7269c2
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From d3699f97a72d417a9555c41792d22ee03c7269c2 Mon Sep 17 00:00:00 2001
From: Ariel Otilibili <otilibil at eurecom.fr>
Date: Wed, 15 Jan 2025 13:11:51 +0100
Subject: [PATCH] net/sfc: remove unnecessary assignment
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit de87641d5c004ef505d58d542a66d66f6a1cb2be ]
The same field was being set twice.
Coverity issue: 384444
Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure")
Signed-off-by: Ariel Otilibili <otilibil at eurecom.fr>
---
drivers/net/sfc/sfc_repr.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/sfc/sfc_repr.c b/drivers/net/sfc/sfc_repr.c
index c2e5d4eb9e..2c1421b959 100644
--- a/drivers/net/sfc/sfc_repr.c
+++ b/drivers/net/sfc/sfc_repr.c
@@ -769,11 +769,7 @@ static void
sfc_repr_close(struct sfc_repr *sr)
{
SFC_ASSERT(sfc_repr_lock_is_locked(sr));
-
SFC_ASSERT(sr->state == SFC_ETHDEV_CONFIGURED);
- sr->state = SFC_ETHDEV_CLOSING;
-
- /* Put representor close actions here */
sr->state = SFC_ETHDEV_INITIALIZED;
}
--
2.34.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-02-18 19:39:01.253376840 +0800
+++ 0014-net-sfc-remove-unnecessary-assignment.patch 2025-02-18 19:39:00.438244080 +0800
@@ -1 +1 @@
-From de87641d5c004ef505d58d542a66d66f6a1cb2be Mon Sep 17 00:00:00 2001
+From d3699f97a72d417a9555c41792d22ee03c7269c2 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit de87641d5c004ef505d58d542a66d66f6a1cb2be ]
@@ -10 +12,0 @@
-Cc: stable at dpdk.org
More information about the stable
mailing list