patch 'net/igc/base: fix iterator type' has been queued to stable release 23.11.4

Xueming Li xuemingl at nvidia.com
Tue Feb 18 13:34:49 CET 2025


Hi,

FYI, your patch has been queued to stable release 23.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
Please shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=6268d4391b5c00a1b43c5f5ab7e106bf0b80ce9e

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 6268d4391b5c00a1b43c5f5ab7e106bf0b80ce9e Mon Sep 17 00:00:00 2001
From: Amir Avivi <amir.avivi at intel.com>
Date: Thu, 6 Feb 2025 16:08:33 +0000
Subject: [PATCH] net/igc/base: fix iterator type
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit c7da9dab82190564d68f0d928ba3e381dcc74d9f ]

Fix static analysis warning about comparison between types of
incompatible width, which might lead to an infinite loop due to
overflow.

Fixes: 8cb7c57d9b3c ("net/igc: support device initialization")

Signed-off-by: Amir Avivi <amir.avivi at intel.com>
Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
 .mailmap                       | 1 +
 drivers/net/igc/base/igc_phy.c | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/.mailmap b/.mailmap
index acf910ab3b..b479ac34a0 100644
--- a/.mailmap
+++ b/.mailmap
@@ -80,6 +80,7 @@ Amaranath Somalapuram <asomalap at amd.com>
 Amine Kherbouche <amine.kherbouche at 6wind.com>
 Amin Tootoonchian <amint at icsi.berkeley.edu>
 Ami Sabo <amis at radware.com>
+Amir Avivi <amir.avivi at intel.com>
 Amit Bernstein <amitbern at amazon.com>
 Amit Gupta <agupta3 at marvell.com>
 Amit Prakash Shukla <amitprakashs at marvell.com>
diff --git a/drivers/net/igc/base/igc_phy.c b/drivers/net/igc/base/igc_phy.c
index 706f037f0e..dd56b994af 100644
--- a/drivers/net/igc/base/igc_phy.c
+++ b/drivers/net/igc/base/igc_phy.c
@@ -2366,7 +2366,8 @@ s32 igc_phy_has_link_generic(struct igc_hw *hw, u32 iterations,
 			       u32 usec_interval, bool *success)
 {
 	s32 ret_val = IGC_SUCCESS;
-	u16 i, phy_status;
+	u16 phy_status;
+	u32 i;

 	DEBUGFUNC("igc_phy_has_link_generic");

--
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2025-02-18 19:39:02.639875401 +0800
+++ 0054-net-igc-base-fix-iterator-type.patch	2025-02-18 19:39:00.648244044 +0800
@@ -1 +1 @@
-From c7da9dab82190564d68f0d928ba3e381dcc74d9f Mon Sep 17 00:00:00 2001
+From 6268d4391b5c00a1b43c5f5ab7e106bf0b80ce9e Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit c7da9dab82190564d68f0d928ba3e381dcc74d9f ]
@@ -11 +13,0 @@
-Cc: stable at dpdk.org
@@ -17,2 +19,2 @@
- .mailmap                             | 1 +
- drivers/net/intel/igc/base/igc_phy.c | 3 ++-
+ .mailmap                       | 1 +
+ drivers/net/igc/base/igc_phy.c | 3 ++-
@@ -22 +24 @@
-index 9ea6bd1df3..ab03985acd 100644
+index acf910ab3b..b479ac34a0 100644
@@ -25 +27 @@
-@@ -84,6 +84,7 @@ Amaranath Somalapuram <asomalap at amd.com>
+@@ -80,6 +80,7 @@ Amaranath Somalapuram <asomalap at amd.com>
@@ -33 +35 @@
-diff --git a/drivers/net/intel/igc/base/igc_phy.c b/drivers/net/intel/igc/base/igc_phy.c
+diff --git a/drivers/net/igc/base/igc_phy.c b/drivers/net/igc/base/igc_phy.c
@@ -35,2 +37,2 @@
---- a/drivers/net/intel/igc/base/igc_phy.c
-+++ b/drivers/net/intel/igc/base/igc_phy.c
+--- a/drivers/net/igc/base/igc_phy.c
++++ b/drivers/net/igc/base/igc_phy.c


More information about the stable mailing list