patch 'net/e1000/base: fix uninitialized variable' has been queued to stable release 23.11.4

Xueming Li xuemingl at nvidia.com
Tue Feb 18 13:34:58 CET 2025


Hi,

FYI, your patch has been queued to stable release 23.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
Please shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=ab2ad1b126e0eedf153583c78e87ced7ac03b699

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From ab2ad1b126e0eedf153583c78e87ced7ac03b699 Mon Sep 17 00:00:00 2001
From: Jakub Buchocki <jakubx.buchocki at intel.com>
Date: Thu, 6 Feb 2025 16:08:42 +0000
Subject: [PATCH] net/e1000/base: fix uninitialized variable
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 4be9a7008efe063fbd326fea9965f946c8969039 ]

Static analysis has detected potential usage of uninitialized values
inside the array. Fix the warning by initializing array.

Fixes: af75078fece3 ("first public release")

Signed-off-by: Jakub Buchocki <jakubx.buchocki at intel.com>
Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
 .mailmap                          | 1 +
 drivers/net/e1000/base/e1000_vf.c | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.mailmap b/.mailmap
index b479ac34a0..90b3d473b7 100644
--- a/.mailmap
+++ b/.mailmap
@@ -585,6 +585,7 @@ Jacek Naczyk <jacek.naczyk at intel.com>
 Jacek Piasecki <jacekx.piasecki at intel.com>
 Jacek Siuda <jck at semihalf.com>
 Jacob Keller <jacob.e.keller at intel.com>
+Jakub Buchocki <jakubx.buchocki at intel.com>
 Jakub Chylkowski <jakubx.chylkowski at intel.com>
 Jakub Grajciar <jgrajcia at cisco.com>
 Jakub Neruda <neruda at netcope.com>
diff --git a/drivers/net/e1000/base/e1000_vf.c b/drivers/net/e1000/base/e1000_vf.c
index fc30357c17..472b921b6f 100644
--- a/drivers/net/e1000/base/e1000_vf.c
+++ b/drivers/net/e1000/base/e1000_vf.c
@@ -376,7 +376,7 @@ STATIC void e1000_write_msg_read_ack(struct e1000_hw *hw,
 void e1000_update_mc_addr_list_vf(struct e1000_hw *hw,
 				  u8 *mc_addr_list, u32 mc_addr_count)
 {
-	u32 msgbuf[E1000_VFMAILBOX_SIZE];
+	u32 msgbuf[E1000_VFMAILBOX_SIZE] = {0};
 	u16 *hash_list = (u16 *)&msgbuf[1];
 	u32 hash_value;
 	u32 i;
--
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2025-02-18 19:39:02.935028950 +0800
+++ 0063-net-e1000-base-fix-uninitialized-variable.patch	2025-02-18 19:39:00.668244041 +0800
@@ -1 +1 @@
-From 4be9a7008efe063fbd326fea9965f946c8969039 Mon Sep 17 00:00:00 2001
+From ab2ad1b126e0eedf153583c78e87ced7ac03b699 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 4be9a7008efe063fbd326fea9965f946c8969039 ]
@@ -10 +12,0 @@
-Cc: stable at dpdk.org
@@ -16,2 +18,2 @@
- .mailmap                                | 1 +
- drivers/net/intel/e1000/base/e1000_vf.c | 2 +-
+ .mailmap                          | 1 +
+ drivers/net/e1000/base/e1000_vf.c | 2 +-
@@ -21 +23 @@
-index ab03985acd..af83b4e129 100644
+index b479ac34a0..90b3d473b7 100644
@@ -24 +26,2 @@
-@@ -620,6 +620,7 @@ Jacek Piasecki <jacekx.piasecki at intel.com>
+@@ -585,6 +585,7 @@ Jacek Naczyk <jacek.naczyk at intel.com>
+ Jacek Piasecki <jacekx.piasecki at intel.com>
@@ -26 +28,0 @@
- Jack Bond-Preston <jack.bond-preston at foss.arm.com> <jack.bond-preston at arm.com>
@@ -32 +34 @@
-diff --git a/drivers/net/intel/e1000/base/e1000_vf.c b/drivers/net/intel/e1000/base/e1000_vf.c
+diff --git a/drivers/net/e1000/base/e1000_vf.c b/drivers/net/e1000/base/e1000_vf.c
@@ -34,2 +36,2 @@
---- a/drivers/net/intel/e1000/base/e1000_vf.c
-+++ b/drivers/net/intel/e1000/base/e1000_vf.c
+--- a/drivers/net/e1000/base/e1000_vf.c
++++ b/drivers/net/e1000/base/e1000_vf.c


More information about the stable mailing list