patch 'net/cpfl: fix representor parsing log' has been queued to stable release 23.11.4

[Xueming Li]

Hi,

FYI, your patch has been queued to stable release 23.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
Please shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=b72de1a305023ba4c040be69aff2d67593a8414b

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From b72de1a305023ba4c040be69aff2d67593a8414b Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Wed, 5 Feb 2025 08:23:03 -0800
Subject: [PATCH] net/cpfl: fix representor parsing log
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 7501478b95fc79b178fc525246482215a6018651 ]

The log message would always refer to str variable which
is NULL here. Looks like author intended to print original
parameter.

Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: 65899b9e6538 ("net/cpfl: parse representor devargs")

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
 drivers/net/cpfl/cpfl_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c
index 7697aea0ce..c24dfba575 100644
--- a/drivers/net/cpfl/cpfl_ethdev.c
+++ b/drivers/net/cpfl/cpfl_ethdev.c
@@ -1576,7 +1576,7 @@ parse_repr(const char *key __rte_unused, const char *value, void *args)
 		RTE_DIM(eth_da->representor_ports));
 done:
 	if (str == NULL) {
-		RTE_LOG(ERR, EAL, "wrong representor format: %s\n", str);
+		PMD_DRV_LOG(ERR, "wrong representor format: %s", value);
 		return -1;
 	}

--
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2025-02-18 19:39:03.284908990 +0800
+++ 0074-net-cpfl-fix-representor-parsing-log.patch	2025-02-18 19:39:00.708244034 +0800
@@ -1 +1 @@
-From 7501478b95fc79b178fc525246482215a6018651 Mon Sep 17 00:00:00 2001
+From b72de1a305023ba4c040be69aff2d67593a8414b Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 7501478b95fc79b178fc525246482215a6018651 ]
@@ -12 +14,0 @@
-Cc: stable at dpdk.org
@@ -16 +18 @@
- drivers/net/intel/cpfl/cpfl_ethdev.c | 2 +-
+ drivers/net/cpfl/cpfl_ethdev.c | 2 +-
@@ -19,5 +21,5 @@
-diff --git a/drivers/net/intel/cpfl/cpfl_ethdev.c b/drivers/net/intel/cpfl/cpfl_ethdev.c
-index 6f6707a0bd..1817221652 100644
---- a/drivers/net/intel/cpfl/cpfl_ethdev.c
-+++ b/drivers/net/intel/cpfl/cpfl_ethdev.c
-@@ -1580,7 +1580,7 @@ parse_repr(const char *key __rte_unused, const char *value, void *args)
+diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c
+index 7697aea0ce..c24dfba575 100644
+--- a/drivers/net/cpfl/cpfl_ethdev.c
++++ b/drivers/net/cpfl/cpfl_ethdev.c
+@@ -1576,7 +1576,7 @@ parse_repr(const char *key __rte_unused, const char *value, void *args)
@@ -27 +29 @@
--		PMD_DRV_LOG(ERR, "wrong representor format: %s", str);
+-		RTE_LOG(ERR, EAL, "wrong representor format: %s\n", str);