patch 'net/nfp: fix hash key length logic' has been queued to stable release 24.11.3

[Kevin Traynor]

Hi,

FYI, your patch has been queued to stable release 24.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/23/25. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/55c400bab9a7541cec577f78a069e474bf251213

Thanks.

Kevin

---
>From 55c400bab9a7541cec577f78a069e474bf251213 Mon Sep 17 00:00:00 2001
From: Chaoyong He <chaoyong.he at corigine.com>
Date: Tue, 1 Apr 2025 07:09:31 -0700
Subject: [PATCH] net/nfp: fix hash key length logic

[ upstream commit 346a007e161e68950acbf59984fefc2bb6fe3982 ]

There does not exist an API for driver to get/set the hash key length
from/to the firmware.
---
 drivers/net/nfp/nfp_net_common.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c
index 600fcd5c0e..df89595773 100644
--- a/drivers/net/nfp/nfp_net_common.c
+++ b/drivers/net/nfp/nfp_net_common.c
@@ -1967,7 +1967,4 @@ nfp_net_rss_hash_write(struct rte_eth_dev *dev,
 	nn_cfg_writel(hw, NFP_NET_CFG_RSS_CTRL, cfg_rss_ctrl);
 
-	/* Writing the key size */
-	nn_cfg_writeb(hw, NFP_NET_CFG_RSS_KEY_SZ, rss_conf->rss_key_len);
-
 	return 0;
 }
@@ -2060,5 +2057,5 @@ nfp_net_rss_hash_conf_get(struct rte_eth_dev *dev,
 
 	/* Reading the key size */
-	rss_conf->rss_key_len = nn_cfg_readl(hw, NFP_NET_CFG_RSS_KEY_SZ);
+	rss_conf->rss_key_len = NFP_NET_CFG_RSS_KEY_SZ;
 
 	/* Reading the key byte a byte */
-- 
2.50.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2025-07-18 20:29:12.442880085 +0100
+++ 0038-net-nfp-fix-hash-key-length-logic.patch	2025-07-18 20:29:10.910907270 +0100
@@ -1 +1 @@
-From 346a007e161e68950acbf59984fefc2bb6fe3982 Mon Sep 17 00:00:00 2001
+From 55c400bab9a7541cec577f78a069e474bf251213 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 346a007e161e68950acbf59984fefc2bb6fe3982 ]
+
@@ -8,15 +9,0 @@
----
-	#define NFP_NET_CFG_RSS_KEY_SZ          0x28
-	#define NFP_NET_CFG_MACADDR             0x0024
----
-
-The original logic try to use the 'NFP_NET_CFG_RSS_KEY_SZ' as the
-inexistent API, read from this address will get wrong hash key length
-and write to this address will overwrite the MAC address unexpected,
-which will cause very strange problem.
-
-Fixes: 934e4c60fbff ("nfp: add RSS")
-Cc: stable at dpdk.org
-
-Signed-off-by: Chaoyong He <chaoyong.he at corigine.com>
-Reviewed-by: Peng Zhang <peng.zhang at corigine.com>