patch 'app/testpmd: fix flow random item token' has been queued to stable release 24.11.3
Kevin Traynor
ktraynor at redhat.com
Fri Jul 18 21:29:52 CEST 2025
Hi,
FYI, your patch has been queued to stable release 24.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/23/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/9449422de54736cb72098da745b37f05e8e33e1e
Thanks.
Kevin
---
>From 9449422de54736cb72098da745b37f05e8e33e1e Mon Sep 17 00:00:00 2001
From: Gregory Etelson <getelson at nvidia.com>
Date: Mon, 19 May 2025 09:30:45 +0300
Subject: [PATCH] app/testpmd: fix flow random item token
[ upstream commit 9a18070e3fe43cd45fc5f000452853a0a45d25c2 ]
ITEM_RANDOM_VALUE token initializes 32 bits mask argument value from
a constant source buffer.
Testpmd initiated the mast value from the 3 bytes buffer -
[0xff, 0xff, 0x00].
When testpmd copied that value to 32 bits mask it accessed a memory
byte outside the source buffer.
The patch fixes the source buffer size.
Fixes: 738ef8f7c706 ("ethdev: add flow item for random matching")
Signed-off-by: Gregory Etelson <getelson at nvidia.com>
---
app/test-pmd/cmdline_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 835fc3690d..eb26333759 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -5583,5 +5583,5 @@ static const struct token token_list[] = {
item_param),
.args = ARGS(ARGS_ENTRY_MASK(struct rte_flow_item_random,
- value, "\xff\xff")),
+ value, "\x00\x00\xff\xff")),
},
[ITEM_GRE_KEY] = {
--
2.50.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-07-18 20:29:13.093392747 +0100
+++ 0058-app-testpmd-fix-flow-random-item-token.patch 2025-07-18 20:29:10.954907405 +0100
@@ -1 +1 @@
-From 9a18070e3fe43cd45fc5f000452853a0a45d25c2 Mon Sep 17 00:00:00 2001
+From 9449422de54736cb72098da745b37f05e8e33e1e Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 9a18070e3fe43cd45fc5f000452853a0a45d25c2 ]
+
@@ -17 +18,0 @@
-Cc: stable at dpdk.org
@@ -25 +26 @@
-index 998527590f..fc807ad8cf 100644
+index 835fc3690d..eb26333759 100644
@@ -28 +29 @@
-@@ -5592,5 +5592,5 @@ static const struct token token_list[] = {
+@@ -5583,5 +5583,5 @@ static const struct token token_list[] = {
More information about the stable
mailing list