patch 'ethdev: fix error struct in flow configure' has been queued to stable release 24.11.3

[Kevin Traynor]

Hi,

FYI, your patch has been queued to stable release 24.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/23/25. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/e743b62f364744bdeeb256a14fda31523c72291c

Thanks.

Kevin

---
>From e743b62f364744bdeeb256a14fda31523c72291c Mon Sep 17 00:00:00 2001
From: Maayan Kashani <mkashani at nvidia.com>
Date: Thu, 29 May 2025 08:56:10 +0300
Subject: [PATCH] ethdev: fix error struct in flow configure

[ upstream commit af7ac22d8da82398065d5f3c799c17a7cec3a6af ]

rte_flow_configure() returned error value w/o filling the
error struct which caused a crash on complain function.

Filling the error struct fixed the issue.

Fixes: 4ff58b734bc9 ("ethdev: introduce flow engine configuration")

Signed-off-by: Maayan Kashani <mkashani at nvidia.com>
---
 lib/ethdev/rte_flow.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c
index 4a7735b5ab..9a14242965 100644
--- a/lib/ethdev/rte_flow.c
+++ b/lib/ethdev/rte_flow.c
@@ -1694,5 +1694,5 @@ rte_flow_configure(uint16_t port_id,
 			"Device with port_id=%"PRIu16" is not configured.",
 			port_id);
-		return -EINVAL;
+		goto error;
 	}
 	if (dev->data->dev_started != 0) {
@@ -1700,13 +1700,13 @@ rte_flow_configure(uint16_t port_id,
 			"Device with port_id=%"PRIu16" already started.",
 			port_id);
-		return -EINVAL;
+		goto error;
 	}
 	if (port_attr == NULL) {
 		FLOW_LOG(ERR, "Port %"PRIu16" info is NULL.", port_id);
-		return -EINVAL;
+		goto error;
 	}
 	if (queue_attr == NULL) {
 		FLOW_LOG(ERR, "Port %"PRIu16" queue info is NULL.", port_id);
-		return -EINVAL;
+		goto error;
 	}
 	if ((port_attr->flags & RTE_FLOW_PORT_FLAG_SHARE_INDIRECT) &&
@@ -1729,4 +1729,8 @@ rte_flow_configure(uint16_t port_id,
 				  RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
 				  NULL, rte_strerror(ENOTSUP));
+error:
+	return rte_flow_error_set(error, EINVAL,
+				  RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
+				  NULL, rte_strerror(EINVAL));
 }
 
-- 
2.50.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2025-07-18 20:29:13.573770473 +0100
+++ 0073-ethdev-fix-error-struct-in-flow-configure.patch	2025-07-18 20:29:10.973907463 +0100
@@ -1 +1 @@
-From af7ac22d8da82398065d5f3c799c17a7cec3a6af Mon Sep 17 00:00:00 2001
+From e743b62f364744bdeeb256a14fda31523c72291c Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit af7ac22d8da82398065d5f3c799c17a7cec3a6af ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index 9f8d8f3dc2..fe8f43caff 100644
+index 4a7735b5ab..9a14242965 100644
@@ -23 +24 @@
-@@ -1726,5 +1726,5 @@ rte_flow_configure(uint16_t port_id,
+@@ -1694,5 +1694,5 @@ rte_flow_configure(uint16_t port_id,
@@ -30 +31 @@
-@@ -1732,13 +1732,13 @@ rte_flow_configure(uint16_t port_id,
+@@ -1700,13 +1700,13 @@ rte_flow_configure(uint16_t port_id,
@@ -47 +48 @@
-@@ -1761,4 +1761,8 @@ rte_flow_configure(uint16_t port_id,
+@@ -1729,4 +1729,8 @@ rte_flow_configure(uint16_t port_id,