patch 'net/mlx5: fix link on Windows' has been queued to stable release 24.11.3

Kevin Traynor ktraynor at redhat.com
Fri Jul 18 21:30:29 CEST 2025


Hi,

FYI, your patch has been queued to stable release 24.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/23/25. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/e225716e63cda946eef8e50956492e2581731c88

Thanks.

Kevin

---
>From e225716e63cda946eef8e50956492e2581731c88 Mon Sep 17 00:00:00 2001
From: Andre Muezerie <andremue at linux.microsoft.com>
Date: Mon, 5 May 2025 07:45:37 -0700
Subject: [PATCH] net/mlx5: fix link on Windows

[ upstream commit 4031a5f261754ad5d4125e84888316d0678f43e7 ]

When compiling DPDK with mlx5 using clang on Windows with
"debug" buildtype the error below is hit:

net_mlx5_mlx5_flow_dv.c.obj : error LNK2019: unresolved external symbol
    mlx5_geneve_tlv_parser_create referenced in function
    flow_dv_discover_priorities
drivers\rte_net_mlx5-25.dll : fatal error LNK1120: 1 unresolved externals

With a "release" buildtype the error is not seen, which explains why this
issue was not reported earlier.

The same problem will show up with MSVC, but patches which are still under
review are needed for this to be hit with MSVC.

The cause of this problem seems to be that mlx5_flow_geneve.c is only
compiled on Linux. This patch fixes the issue by compiling the file on all
operating systems. It also sorts the file names in meson.build in
alphabetical order.

Fixes: f5177bdc8b76 ("net/mlx5: add GENEVE TLV options parser API")

Signed-off-by: Andre Muezerie <andremue at linux.microsoft.com>
Acked-by: Dariusz Sosnowski <dsosnowski at nvidia.com>
---
 drivers/net/mlx5/meson.build | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build
index 78a8648b43..6a91692759 100644
--- a/drivers/net/mlx5/meson.build
+++ b/drivers/net/mlx5/meson.build
@@ -18,11 +18,14 @@ headers = files('rte_pmd_mlx5.h')
 sources = files(
         'mlx5.c',
+        'mlx5_devx.c',
         'mlx5_ethdev.c',
         'mlx5_flow.c',
-        'mlx5_flow_meter.c',
-        'mlx5_flow_dv.c',
         'mlx5_flow_aso.c',
+        'mlx5_flow_dv.c',
         'mlx5_flow_flex.c',
+        'mlx5_flow_geneve.c',
+        'mlx5_flow_meter.c',
         'mlx5_mac.c',
+        'mlx5_nta_rss.c',
         'mlx5_rss.c',
         'mlx5_rx.c',
@@ -31,6 +34,6 @@ sources = files(
         'mlx5_rxtx.c',
         'mlx5_stats.c',
-        'mlx5_trigger.c',
         'mlx5_trace.c',
+        'mlx5_trigger.c',
         'mlx5_tx.c',
         'mlx5_tx_empw.c',
@@ -38,19 +41,16 @@ sources = files(
         'mlx5_tx_nompw.c',
         'mlx5_tx_txpp.c',
-        'mlx5_txq.c',
         'mlx5_txpp.c',
-        'mlx5_vlan.c',
+        'mlx5_txq.c',
         'mlx5_utils.c',
-        'mlx5_devx.c',
-        'mlx5_nta_rss.c',
+        'mlx5_vlan.c',
 )
 
 if is_linux
     sources += files(
-            'mlx5_flow_geneve.c',
             'mlx5_flow_hw.c',
-            'mlx5_hws_cnt.c',
             'mlx5_flow_quota.c',
             'mlx5_flow_verbs.c',
+            'mlx5_hws_cnt.c',
             'mlx5_nta_split.c',
     )
-- 
2.50.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2025-07-18 20:29:14.300654657 +0100
+++ 0095-net-mlx5-fix-link-on-Windows.patch	2025-07-18 20:29:11.001907548 +0100
@@ -1 +1 @@
-From 4031a5f261754ad5d4125e84888316d0678f43e7 Mon Sep 17 00:00:00 2001
+From e225716e63cda946eef8e50956492e2581731c88 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 4031a5f261754ad5d4125e84888316d0678f43e7 ]
+
@@ -26 +27,0 @@
-Cc: stable at dpdk.org



More information about the stable mailing list