patch 'examples/ipsec-secgw: fix crash in event vector mode' has been queued to stable release 23.11.5
Xueming Li
xuemingl at nvidia.com
Wed Jul 30 09:10:20 CEST 2025
Hi,
FYI, your patch has been queued to stable release 23.11.5
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/10/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=905ff393d18b024b7663cec7cfde74f28200b59d
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From 905ff393d18b024b7663cec7cfde74f28200b59d Mon Sep 17 00:00:00 2001
From: Rakesh Kudurumalla <rkudurumalla at marvell.com>
Date: Wed, 18 Jun 2025 14:00:06 +0530
Subject: [PATCH] examples/ipsec-secgw: fix crash in event vector mode
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit 811383ef109d8dae04c0681b84de09c51f153543 ]
Launching ipsec-secgw application in event vector mode
after traffic has started results in segfault because
we are receiving few IPSec packet and application is trying
to decrypt IPsec packets using lookaside protocol.
This contradicts inline event mode.This patch fixes the same
by freeing IPsec packets and processing only plain packets.
Fixes: 1d5078c6cf19 ("examples/ipsec-secgw: support event vector in lookaside mode")
Signed-off-by: Rakesh Kudurumalla <rkudurumalla at marvell.com>
Acked-by: Akhil Goyal <gakhil at marvell.com>
---
examples/ipsec-secgw/ipsec_worker.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/examples/ipsec-secgw/ipsec_worker.c b/examples/ipsec-secgw/ipsec_worker.c
index c9c43ebd2b..7d45300192 100644
--- a/examples/ipsec-secgw/ipsec_worker.c
+++ b/examples/ipsec-secgw/ipsec_worker.c
@@ -705,6 +705,9 @@ ipsec_ev_inbound_route_pkts(struct rte_event_vector *vec,
struct rte_ipsec_session *sess;
struct rte_mbuf *pkt;
struct ipsec_sa *sa;
+ uint8_t mask = (1UL << RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO) |
+ (1UL << RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL);
+
j = ipsec_ev_route_ip_pkts(vec, rt, t);
@@ -712,7 +715,7 @@ ipsec_ev_inbound_route_pkts(struct rte_event_vector *vec,
for (i = 0; i < t->ipsec.num; i++) {
pkt = t->ipsec.pkts[i];
sa = ipsec_mask_saptr(t->ipsec.saptr[i]);
- if (unlikely(sa == NULL)) {
+ if (unlikely(sa == NULL) || ((1UL << sa->sessions[0].type) & mask)) {
free_pkts(&pkt, 1);
continue;
}
--
2.34.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-07-30 15:02:13.093606313 +0800
+++ 0009-examples-ipsec-secgw-fix-crash-in-event-vector-mode.patch 2025-07-30 15:02:12.774913471 +0800
@@ -1 +1 @@
-From 811383ef109d8dae04c0681b84de09c51f153543 Mon Sep 17 00:00:00 2001
+From 905ff393d18b024b7663cec7cfde74f28200b59d Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 811383ef109d8dae04c0681b84de09c51f153543 ]
@@ -14 +16,0 @@
-Cc: stable at dpdk.org
@@ -23 +25 @@
-index e0690fc8d9..04609964cd 100644
+index c9c43ebd2b..7d45300192 100644
@@ -26 +28 @@
-@@ -700,6 +700,9 @@ ipsec_ev_inbound_route_pkts(struct rte_event_vector *vec,
+@@ -705,6 +705,9 @@ ipsec_ev_inbound_route_pkts(struct rte_event_vector *vec,
@@ -36 +38 @@
-@@ -707,7 +710,7 @@ ipsec_ev_inbound_route_pkts(struct rte_event_vector *vec,
+@@ -712,7 +715,7 @@ ipsec_ev_inbound_route_pkts(struct rte_event_vector *vec,
More information about the stable
mailing list