patch 'net/tap: fix qdisc add failure handling' has been queued to stable release 23.11.5

[Xueming Li]

Hi,

FYI, your patch has been queued to stable release 23.11.5

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/28/25. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=9a33966ea38cc61e79b9577faeee47ce713fe3ad

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 9a33966ea38cc61e79b9577faeee47ce713fe3ad Mon Sep 17 00:00:00 2001
From: Yan Lu <luyan at cmss.chinamobile.com>
Date: Wed, 21 May 2025 09:33:13 +0800
Subject: [PATCH] net/tap: fix qdisc add failure handling
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 02a68649e6fb55d8975c726e3073ee9d12c20bac ]

The errno variable was assigned a positive value in the previous handling,
but here it is compared against -EEXIST,
When the tap already exists, this would falsely report an error.

Fixes: 6fc6de7e0eaf ("net/tap: update netlink error code management")

Signed-off-by: Yan Lu <luyan at cmss.chinamobile.com>
---
 .mailmap                     | 1 +
 drivers/net/tap/tap_tcmsgs.c | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/.mailmap b/.mailmap
index 20fa4a22ba..b4e75a6046 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1639,6 +1639,7 @@ Yanglong Wu <yanglong.wu at intel.com>
 Yang Ming <ming.1.yang at nokia-sbell.com>
 Yang Zhang <zy107165 at alibaba-inc.com>
 Yanjie Xu <yanjie.xu at intel.com>
+Yan Lu <luyan at cmss.chinamobile.com>
 Yan Xia <yanx.xia at intel.com>
 Yao-Po Wang <blue119 at gmail.com>
 Yao Zhao <yao.zhao at windriver.com>
diff --git a/drivers/net/tap/tap_tcmsgs.c b/drivers/net/tap/tap_tcmsgs.c
index a3aae3c814..24a0423a0e 100644
--- a/drivers/net/tap/tap_tcmsgs.c
+++ b/drivers/net/tap/tap_tcmsgs.c
@@ -261,7 +261,7 @@ qdisc_create_multiq(int nlsk_fd, unsigned int ifindex)
 	int err = 0;
 
 	err = qdisc_add_multiq(nlsk_fd, ifindex);
-	if (err < 0 && errno != -EEXIST) {
+	if (err < 0 && errno != EEXIST) {
 		TAP_LOG(ERR, "Could not add multiq qdisc (%d): %s",
 			errno, strerror(errno));
 		return -1;
@@ -287,7 +287,7 @@ qdisc_create_ingress(int nlsk_fd, unsigned int ifindex)
 	int err = 0;
 
 	err = qdisc_add_ingress(nlsk_fd, ifindex);
-	if (err < 0 && errno != -EEXIST) {
+	if (err < 0 && errno != EEXIST) {
 		TAP_LOG(ERR, "Could not add ingress qdisc (%d): %s",
 			errno, strerror(errno));
 		return -1;
-- 
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2025-06-26 19:59:19.861836541 +0800
+++ 0053-net-tap-fix-qdisc-add-failure-handling.patch	2025-06-26 19:59:17.422418042 +0800
@@ -1 +1 @@
-From 02a68649e6fb55d8975c726e3073ee9d12c20bac Mon Sep 17 00:00:00 2001
+From 9a33966ea38cc61e79b9577faeee47ce713fe3ad Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 02a68649e6fb55d8975c726e3073ee9d12c20bac ]
@@ -11 +13,0 @@
-Cc: stable at dpdk.org
@@ -20 +22 @@
-index 59ee5f7d30..df3674cc7f 100644
+index 20fa4a22ba..b4e75a6046 100644
@@ -23 +25,2 @@
-@@ -1746,6 +1746,7 @@ Yang Ming <ming.1.yang at nokia-sbell.com>
+@@ -1639,6 +1639,7 @@ Yanglong Wu <yanglong.wu at intel.com>
+ Yang Ming <ming.1.yang at nokia-sbell.com>
@@ -25 +27,0 @@
- Yaniv Rosner <yrosner at nvidia.com>
@@ -32 +34 @@
-index 1755b57519..caca9445c8 100644
+index a3aae3c814..24a0423a0e 100644