patch 'net/ixgbe: fix minimum Rx/Tx descriptors' has been queued to stable release 22.11.8

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 22.11.8

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/09/25. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/a1cc0b5adae53f811a6d25ff9758c5c7e9c7cdff

Thanks.

Luca Boccassi

---
>From a1cc0b5adae53f811a6d25ff9758c5c7e9c7cdff Mon Sep 17 00:00:00 2001
From: Mingjin Ye <mingjinx.ye at intel.com>
Date: Tue, 25 Feb 2025 09:12:36 +0000
Subject: [PATCH] net/ixgbe: fix minimum Rx/Tx descriptors

[ upstream commit 6808ee1ceddc76846f80ae3d05aad374a34a1754 ]

The minimum free packet threshold (tx_free_thresh) and the minimum RS bit
threshold (tx_rs_thresh) both have a default value of 32. Therefore, the
default minimum number of ring descriptors value is 64.

For reference, see "Configuration of Transmit Queues" in
doc/guides/prog_guide/ethdev/ethdev.rst

Fixes: dee5f1fd5fc7 ("ixgbe: get queue info and descriptor limits")

Signed-off-by: Mingjin Ye <mingjinx.ye at intel.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
 doc/guides/nics/ixgbe.rst      | 8 +++-----
 drivers/net/ixgbe/ixgbe_rxtx.h | 2 +-
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst
index f8eedb4c7f..dc9049f150 100644
--- a/doc/guides/nics/ixgbe.rst
+++ b/doc/guides/nics/ixgbe.rst
@@ -37,14 +37,12 @@ Ensure that the following pre-conditions are satisfied:
 
 *   (rxq->nb_rx_desc % rxq->rx_free_thresh) == 0
 
-*   rxq->nb_rx_desc  < (IXGBE_MAX_RING_DESC - RTE_PMD_IXGBE_RX_MAX_BURST)
+*   rxq->nb_rx_desc >= IXGBE_MIN_RING_DESC
+
+*   rxq->nb_rx_desc <= IXGBE_MAX_RING_DESC
 
 These conditions are checked in the code.
 
-Scattered packets are not supported in this mode.
-If an incoming packet is greater than the maximum acceptable length of one "mbuf" data size (by default, the size is 2 KB),
-vPMD for RX would be disabled.
-
 By default, IXGBE_MAX_RING_DESC is set to 4096 and RTE_PMD_IXGBE_RX_MAX_BURST is set to 32.
 
 Windows Prerequisites and Pre-conditions
diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h b/drivers/net/ixgbe/ixgbe_rxtx.h
index 668a5b9814..3af83b693c 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.h
+++ b/drivers/net/ixgbe/ixgbe_rxtx.h
@@ -24,7 +24,7 @@
  * descriptors should meet the following condition:
  *      (num_ring_desc * sizeof(rx/tx descriptor)) % 128 == 0
  */
-#define	IXGBE_MIN_RING_DESC	32
+#define	IXGBE_MIN_RING_DESC	64
 #define	IXGBE_MAX_RING_DESC	4096
 
 #define RTE_PMD_IXGBE_TX_MAX_BURST 32
-- 
2.47.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2025-03-07 12:23:38.581612404 +0000
+++ 0015-net-ixgbe-fix-minimum-Rx-Tx-descriptors.patch	2025-03-07 12:23:38.014838527 +0000
@@ -1 +1 @@
-From 6808ee1ceddc76846f80ae3d05aad374a34a1754 Mon Sep 17 00:00:00 2001
+From a1cc0b5adae53f811a6d25ff9758c5c7e9c7cdff Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 6808ee1ceddc76846f80ae3d05aad374a34a1754 ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -19,2 +20,2 @@
- doc/guides/nics/ixgbe.rst            | 8 +++-----
- drivers/net/intel/ixgbe/ixgbe_rxtx.h | 2 +-
+ doc/guides/nics/ixgbe.rst      | 8 +++-----
+ drivers/net/ixgbe/ixgbe_rxtx.h | 2 +-
@@ -24 +25 @@
-index 8dcde7ae1c..a03ec7a7e8 100644
+index f8eedb4c7f..dc9049f150 100644
@@ -27 +28 @@
-@@ -68,14 +68,12 @@ Ensure that the following pre-conditions are satisfied:
+@@ -37,14 +37,12 @@ Ensure that the following pre-conditions are satisfied:
@@ -42 +43 @@
- By default, IXGBE_MAX_RING_DESC is set to 8192 and RTE_PMD_IXGBE_RX_MAX_BURST is set to 32.
+ By default, IXGBE_MAX_RING_DESC is set to 4096 and RTE_PMD_IXGBE_RX_MAX_BURST is set to 32.
@@ -45,5 +46,5 @@
-diff --git a/drivers/net/intel/ixgbe/ixgbe_rxtx.h b/drivers/net/intel/ixgbe/ixgbe_rxtx.h
-index 278f665108..54569c7ade 100644
---- a/drivers/net/intel/ixgbe/ixgbe_rxtx.h
-+++ b/drivers/net/intel/ixgbe/ixgbe_rxtx.h
-@@ -26,7 +26,7 @@
+diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h b/drivers/net/ixgbe/ixgbe_rxtx.h
+index 668a5b9814..3af83b693c 100644
+--- a/drivers/net/ixgbe/ixgbe_rxtx.h
++++ b/drivers/net/ixgbe/ixgbe_rxtx.h
+@@ -24,7 +24,7 @@
@@ -55 +56 @@
- #define	IXGBE_MAX_RING_DESC	8192
+ #define	IXGBE_MAX_RING_DESC	4096