patch 'ci: build with MSVC in GHA' has been queued to stable release 24.11.2
Kevin Traynor
ktraynor at redhat.com
Fri Mar 7 13:46:34 CET 2025
Hi,
FYI, your patch has been queued to stable release 24.11.2
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/12/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/e22b7840f4f40661012bc54dc607ab5dd13c41b0
Thanks.
Kevin
---
>From e22b7840f4f40661012bc54dc607ab5dd13c41b0 Mon Sep 17 00:00:00 2001
From: David Marchand <david.marchand at redhat.com>
Date: Wed, 12 Feb 2025 17:46:16 +0100
Subject: [PATCH] ci: build with MSVC in GHA
[ upstream commit 6d80989ab2dcae3d70c0deeccf104c00b49d029c ]
Add a build target in Windows 2022 for MSVC.
Signed-off-by: David Marchand <david.marchand at redhat.com>
Acked-by: Aaron Conole <aconole at redhat.com>
Acked-by: Andre Muezerie <andremue at linux.microsoft.com>
---
.github/workflows/build.yml | 38 +++++++++++++++++++++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index d99700b6e9..cd71805168 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -175,4 +175,42 @@ jobs:
build/meson-logs/testlog.txt
+ windows-vm-builds:
+ name: ${{ join(matrix.config.*, '-') }}
+ runs-on: ${{ matrix.config.os }}
+ strategy:
+ fail-fast: false
+ matrix:
+ config:
+ - os: windows-2022
+ compiler: msvc
+
+ steps:
+ - name: Checkout sources
+ uses: actions/checkout at v4
+ - name: Set up Python
+ uses: actions/setup-python at v5
+ with:
+ python-version: '3.x'
+ - name: Install dependencies
+ run: python -m pip install meson==1.6.1 ninja
+ - name: Configure
+ shell: cmd
+ run: |
+ call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -host_arch=amd64 -arch=amd64
+ meson setup -Denable_stdatomic=true build
+ - name: Build
+ shell: cmd
+ run: |
+ call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -host_arch=amd64 -arch=amd64
+ meson compile -C build
+ - name: Upload logs on failure
+ if: failure()
+ uses: actions/upload-artifact at v4
+ with:
+ name: meson-logs-${{ join(matrix.config.*, '-') }}
+ path: |
+ build/.ninja_log
+ build/meson-logs/meson-log.txt
+
prepare-container-images:
name: ${{ join(matrix.config.*, '-') }}
--
2.48.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-03-07 11:02:56.949845053 +0000
+++ 0001-ci-build-with-MSVC-in-GHA.patch 2025-03-07 11:02:56.785335333 +0000
@@ -1 +1 @@
-From 6d80989ab2dcae3d70c0deeccf104c00b49d029c Mon Sep 17 00:00:00 2001
+From e22b7840f4f40661012bc54dc607ab5dd13c41b0 Mon Sep 17 00:00:00 2001
@@ -6 +6 @@
-Add a build target in Windows 2022 for MSVC.
+[ upstream commit 6d80989ab2dcae3d70c0deeccf104c00b49d029c ]
@@ -8 +8 @@
-Cc: stable at dpdk.org
+Add a build target in Windows 2022 for MSVC.
@@ -18 +18 @@
-index dcafb4a8f5..aef692ca1f 100644
+index d99700b6e9..cd71805168 100644
More information about the stable
mailing list