patch 'app/testpmd: avoid crash in DCB config' has been queued to stable release 24.11.2
Kevin Traynor
ktraynor at redhat.com
Fri Mar 7 13:46:42 CET 2025
Hi,
FYI, your patch has been queued to stable release 24.11.2
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/12/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/399b59e5b45ea86a7b80c915706ad8e276ff1545
Thanks.
Kevin
---
>From 399b59e5b45ea86a7b80c915706ad8e276ff1545 Mon Sep 17 00:00:00 2001
From: Chengwen Feng <fengchengwen at huawei.com>
Date: Thu, 20 Feb 2025 15:06:51 +0800
Subject: [PATCH] app/testpmd: avoid crash in DCB config
[ upstream commit d646e219b34ffc4d531f3703fc317e7cff9a25ae ]
The "port config dcb ..." command will segment fault when input with
invalid port id, this patch fixes it.
Fixes: 9b53e542e9e1 ("app/testpmd: add priority flow control")
Signed-off-by: Chengwen Feng <fengchengwen at huawei.com>
---
app/test-pmd/cmdline.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 7e0666e9f6..93c9fc402d 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -3462,4 +3462,7 @@ cmd_config_dcb_parsed(void *parsed_result,
int ret;
+ if (port_id_is_invalid(port_id, ENABLED_WARN))
+ return;
+
port = &ports[port_id];
/** Check if the port is not started **/
@@ -6664,4 +6667,7 @@ cmd_priority_flow_ctrl_set_parsed(void *parsed_result,
int ret;
+ if (port_id_is_invalid(res->port_id, ENABLED_WARN))
+ return;
+
/*
* Rx on/off, flow control is enabled/disabled on RX side. This can indicate
--
2.48.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-03-07 11:02:57.236248985 +0000
+++ 0009-app-testpmd-avoid-crash-in-DCB-config.patch 2025-03-07 11:02:56.838335561 +0000
@@ -1 +1 @@
-From d646e219b34ffc4d531f3703fc317e7cff9a25ae Mon Sep 17 00:00:00 2001
+From 399b59e5b45ea86a7b80c915706ad8e276ff1545 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit d646e219b34ffc4d531f3703fc317e7cff9a25ae ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -18 +19 @@
-index 6b0d8af4f6..6ca3eedb92 100644
+index 7e0666e9f6..93c9fc402d 100644
@@ -21 +22 @@
-@@ -3463,4 +3463,7 @@ cmd_config_dcb_parsed(void *parsed_result,
+@@ -3462,4 +3462,7 @@ cmd_config_dcb_parsed(void *parsed_result,
@@ -29 +30 @@
-@@ -6665,4 +6668,7 @@ cmd_priority_flow_ctrl_set_parsed(void *parsed_result,
+@@ -6664,4 +6667,7 @@ cmd_priority_flow_ctrl_set_parsed(void *parsed_result,
More information about the stable
mailing list