patch 'net/mlx5: fix leak in HWS flow counter action' has been queued to stable release 24.11.2
Kevin Traynor
ktraynor at redhat.com
Fri Mar 7 13:47:00 CET 2025
Hi,
FYI, your patch has been queued to stable release 24.11.2
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/12/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/daeec245a60a4fc3848a41073438a0471dffe920
Thanks.
Kevin
---
>From daeec245a60a4fc3848a41073438a0471dffe920 Mon Sep 17 00:00:00 2001
From: David Marchand <david.marchand at redhat.com>
Date: Mon, 27 Jan 2025 11:53:47 +0100
Subject: [PATCH] net/mlx5: fix leak in HWS flow counter action
[ upstream commit 9e34fcc81c005a60c919c572ef83c10ebb0201af ]
This was caught by our internal covscan.
mp_name can be leaked in case of errors.
Fixes: 4d368e1da3a4 ("net/mlx5: support flow counter action for HWS")
Signed-off-by: David Marchand <david.marchand at redhat.com>
Acked-by: Dariusz Sosnowski <dsosnowski at nvidia.com>
---
drivers/net/mlx5/mlx5_hws_cnt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_hws_cnt.c b/drivers/net/mlx5/mlx5_hws_cnt.c
index 0197c098f6..eaceedd5ba 100644
--- a/drivers/net/mlx5/mlx5_hws_cnt.c
+++ b/drivers/net/mlx5/mlx5_hws_cnt.c
@@ -724,5 +724,5 @@ mlx5_hws_cnt_pool_create(struct rte_eth_dev *dev,
ret = mlx5_hws_cnt_svc_init(priv->sh, error);
if (ret)
- return ret;
+ goto error;
}
cparam.fetch_sz = HWS_CNT_CACHE_FETCH_DEFAULT;
@@ -768,4 +768,5 @@ error:
mlx5_hws_cnt_pool_destroy(priv->sh, cpool);
priv->hws_cpool = NULL;
+ mlx5_free(mp_name);
return ret;
}
--
2.48.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-03-07 11:02:57.902815983 +0000
+++ 0027-net-mlx5-fix-leak-in-HWS-flow-counter-action.patch 2025-03-07 11:02:56.879599449 +0000
@@ -1 +1 @@
-From 9e34fcc81c005a60c919c572ef83c10ebb0201af Mon Sep 17 00:00:00 2001
+From daeec245a60a4fc3848a41073438a0471dffe920 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 9e34fcc81c005a60c919c572ef83c10ebb0201af ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
More information about the stable
mailing list