patch 'net/iavf: fix crash on app exit on FreeBSD' has been queued to stable release 22.11.8
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Wed Mar 19 15:21:15 CET 2025
Hi,
FYI, your patch has been queued to stable release 22.11.8
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/21/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/ad8a7ddf129931efaebb971ea92d275f0f0728d5
Thanks.
Luca Boccassi
---
>From ad8a7ddf129931efaebb971ea92d275f0f0728d5 Mon Sep 17 00:00:00 2001
From: Bruce Richardson <bruce.richardson at intel.com>
Date: Mon, 10 Mar 2025 13:11:16 +0000
Subject: [PATCH] net/iavf: fix crash on app exit on FreeBSD
[ upstream commit 44a86bcf2447d7d914d7195448285aa82eaedcba ]
With the fallback interrupt path now enabled on FreeBSD there are
segmentation faults on app exit, due to the alarm interrupt trying to
access invalid pointers. Add checks for null to fix these crashes.
Fixes: cd3b124955d4 ("net/iavf: enable interrupt polling")
Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
Acked-by: Vladimir Medvedkin <vladimir.medvedkin at intel.com>
---
drivers/net/iavf/iavf_ethdev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 0ff55a57b4..656a4c6176 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -2529,6 +2529,9 @@ void
iavf_dev_alarm_handler(void *param)
{
struct rte_eth_dev *dev = (struct rte_eth_dev *)param;
+ if (dev == NULL || dev->data == NULL || dev->data->dev_private == NULL)
+ return;
+
struct iavf_hw *hw = IAVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);
uint32_t icr0;
--
2.47.2
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-03-19 14:20:57.230789784 +0000
+++ 0004-net-iavf-fix-crash-on-app-exit-on-FreeBSD.patch 2025-03-19 14:20:57.057288838 +0000
@@ -1 +1 @@
-From 44a86bcf2447d7d914d7195448285aa82eaedcba Mon Sep 17 00:00:00 2001
+From ad8a7ddf129931efaebb971ea92d275f0f0728d5 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 44a86bcf2447d7d914d7195448285aa82eaedcba ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -16 +17 @@
- drivers/net/intel/iavf/iavf_ethdev.c | 3 +++
+ drivers/net/iavf/iavf_ethdev.c | 3 +++
@@ -19,5 +20,5 @@
-diff --git a/drivers/net/intel/iavf/iavf_ethdev.c b/drivers/net/intel/iavf/iavf_ethdev.c
-index 1ab84b0bfc..2335746f04 100644
---- a/drivers/net/intel/iavf/iavf_ethdev.c
-+++ b/drivers/net/intel/iavf/iavf_ethdev.c
-@@ -2698,6 +2698,9 @@ void
+diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
+index 0ff55a57b4..656a4c6176 100644
+--- a/drivers/net/iavf/iavf_ethdev.c
++++ b/drivers/net/iavf/iavf_ethdev.c
+@@ -2529,6 +2529,9 @@ void
More information about the stable
mailing list