patch 'pdump: clear statistics when enabled' has been queued to stable release 22.11.8

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 22.11.8

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/21/25. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/37489c4ec76b13fa4b79cbb0052c4418be665802

Thanks.

Luca Boccassi

---
>From 37489c4ec76b13fa4b79cbb0052c4418be665802 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Thu, 19 Dec 2024 15:58:53 -0800
Subject: [PATCH] pdump: clear statistics when enabled

[ upstream commit b8392fa204ed46b580d61e7621948f1b187c9f98 ]

The pdump statistics are used to keep track of the number
of packets captured, filtered, etc. These need not be cumalative
and instead should be start counting when capture starts.

This fixes the issue where multiple invocations of dumpcap
would include counts from previous invocations.

Bugzilla ID: 1604
Fixes: 10f726efe26c ("pdump: support pcapng and filtering")

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
Acked-by: Vladimir Medvedkin <vladimir.medvedkin at intel.com>
---
 lib/pdump/rte_pdump.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c
index 63835a1a67..016a0c38cf 100644
--- a/lib/pdump/rte_pdump.c
+++ b/lib/pdump/rte_pdump.c
@@ -202,6 +202,8 @@ pdump_register_rx_callbacks(enum pdump_version ver,
 					rte_errno);
 				return rte_errno;
 			}
+
+			memset(&pdump_stats->rx[port][qid], 0, sizeof(struct rte_pdump_stats));
 		} else if (operation == DISABLE) {
 			int ret;
 
@@ -260,6 +262,7 @@ pdump_register_tx_callbacks(enum pdump_version ver,
 					rte_errno);
 				return rte_errno;
 			}
+			memset(&pdump_stats->tx[port][qid], 0, sizeof(struct rte_pdump_stats));
 		} else if (operation == DISABLE) {
 			int ret;
 
-- 
2.47.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2025-03-19 14:20:57.458335455 +0000
+++ 0010-pdump-clear-statistics-when-enabled.patch	2025-03-19 14:20:57.081289241 +0000
@@ -1 +1 @@
-From b8392fa204ed46b580d61e7621948f1b187c9f98 Mon Sep 17 00:00:00 2001
+From 37489c4ec76b13fa4b79cbb0052c4418be665802 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit b8392fa204ed46b580d61e7621948f1b187c9f98 ]
+
@@ -15 +16,0 @@
-Cc: stable at dpdk.org
@@ -25 +26 @@
-index 679c3dd0b5..0e6ffc167b 100644
+index 63835a1a67..016a0c38cf 100644
@@ -28 +29 @@
-@@ -199,6 +199,8 @@ pdump_register_rx_callbacks(enum pdump_version ver,
+@@ -202,6 +202,8 @@ pdump_register_rx_callbacks(enum pdump_version ver,
@@ -37 +38 @@
-@@ -257,6 +259,7 @@ pdump_register_tx_callbacks(enum pdump_version ver,
+@@ -260,6 +262,7 @@ pdump_register_tx_callbacks(enum pdump_version ver,