patch 'examples/vhost_crypto: fix user callbacks' has been queued to stable release 22.11.8

[Luca Boccassi]

On Mon, 31 Mar 2025 at 08:31, Jiang, YuX <yux.jiang at intel.com> wrote:
>
> Hi All,
>
> This patch will cause dpdk-vhost_crypto Segmentation fault (core dumped) when launch qemu.
> Details refer to https://bugs.dpdk.org/show_bug.cgi?id=1685
>
> Best regards,
> Yu Jiang

Thanks for the report, given it's a patch for an example program I'll
revert it for now, it can be brought back for the next release if it
is still needed and it can be fixed.

> > -----Original Message-----
> > From: luca.boccassi at gmail.com <luca.boccassi at gmail.com>
> > Sent: Friday, March 7, 2025 8:24 PM
> > To: Gowrishankar Muthukrishnan <gmuthukrishn at marvell.com>
> > Cc: Akhil Goyal <gakhil at marvell.com>; Maxime Coquelin
> > <maxime.coquelin at redhat.com>; dpdk stable <stable at dpdk.org>
> > Subject: patch 'examples/vhost_crypto: fix user callbacks' has been queued to
> > stable release 22.11.8
> >
> > Hi,
> >
> > FYI, your patch has been queued to stable release 22.11.8
> >
> > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
> > It will be pushed if I get no objections before 03/09/25. So please shout if
> > anyone has objections.
> >
> > Also note that after the patch there's a diff of the upstream commit vs the
> > patch applied to the branch. This will indicate if there was any rebasing needed
> > to apply to the stable branch. If there were code changes for rebasing
> > (ie: not only metadata diffs), please double check that the rebase was correctly
> > done.
> >
> > Queued patches are on a temporary branch at:
> > https://github.com/bluca/dpdk-stable
> >
> > This queued commit can be viewed at:
> > https://github.com/bluca/dpdk-
> > stable/commit/6816d998b04e26ca4468356e0a3c10daf65412eb
> >
> > Thanks.
> >
> > Luca Boccassi
> >
> > ---
> > From 6816d998b04e26ca4468356e0a3c10daf65412eb Mon Sep 17
> > 00:00:00 2001
> > From: Gowrishankar Muthukrishnan <gmuthukrishn at marvell.com>
> > Date: Fri, 28 Feb 2025 19:17:11 +0530
> > Subject: [PATCH] examples/vhost_crypto: fix user callbacks
> >
> > [ upstream commit f7cf44d49b1115238a87c5852db4b47290bfdc25 ]
> >
> > In order to handle new vhost user connection, use new_connection and
> > destroy_connection callbacks.
> >
> > Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
> >
> > Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn at marvell.com>
> > Acked-by: Akhil Goyal <gakhil at marvell.com>
> > Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
> > ---
> >  examples/vhost_crypto/main.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
> > index 02987ebd76..b00daf74e7 100644
> > --- a/examples/vhost_crypto/main.c
> > +++ b/examples/vhost_crypto/main.c
> > @@ -362,8 +362,8 @@ destroy_device(int vid)  }
> >
> >  static const struct rte_vhost_device_ops virtio_crypto_device_ops = {
> > -     .new_device =  new_device,
> > -     .destroy_device = destroy_device,
> > +     .new_connection =  new_device,
> > +     .destroy_connection = destroy_device,
> >  };
> >
> >  static int
> > --
> > 2.47.2
> >
> > ---
> >   Diff of the applied patch vs upstream commit (please double-check if non-
> > empty:
> > ---
> > --- - 2025-03-07 12:23:38.361858825 +0000
> > +++ 0009-examples-vhost_crypto-fix-user-callbacks.patch       2025-03-07
> > 12:23:37.998838059 +0000
> > @@ -1 +1 @@
> > -From f7cf44d49b1115238a87c5852db4b47290bfdc25 Mon Sep 17
> > 00:00:00 2001
> > +From 6816d998b04e26ca4468356e0a3c10daf65412eb Mon Sep 17
> > 00:00:00 2001
> > @@ -5,0 +6,2 @@
> > +[ upstream commit f7cf44d49b1115238a87c5852db4b47290bfdc25 ]
> > +
> > @@ -10 +11,0 @@
> > -Cc: stable at dpdk.org
> > @@ -20 +21 @@
> > -index 558c09a60f..b1fe4120b9 100644
> > +index 02987ebd76..b00daf74e7 100644