patch 'app/testpmd: increase size of set cores list command' has been queued to stable release 24.11.4
Kevin Traynor
ktraynor at redhat.com
Fri Oct 31 15:32:19 CET 2025
Hi,
FYI, your patch has been queued to stable release 24.11.4
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/05/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/7901aecec7ab5c2397b28f4eebc1e86a67e690d6
Thanks.
Kevin
---
>From 7901aecec7ab5c2397b28f4eebc1e86a67e690d6 Mon Sep 17 00:00:00 2001
From: Dengdui Huang <huangdengdui at huawei.com>
Date: Tue, 8 Jul 2025 20:51:59 +0800
Subject: [PATCH] app/testpmd: increase size of set cores list command
[ upstream commit d0f4f0779898e41a940e9a6f83f782750ffbfbb7 ]
The cmdline_fixed_string_t has a length of only 128, which will
become insufficient when there are many cores, so it should be
replaced with a cmdline_multi_string_t of larger capacity.
Fixes: af75078fece3 ("first public release")
Signed-off-by: Dengdui Huang <huangdengdui at huawei.com>
Acked-by: Chengwen Feng <fengchengwen at huawei.com>
---
app/test-pmd/cmdline.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index e92dd9eade..79f8b4fad4 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -3907,5 +3907,5 @@ parse_item_list(const char *str, const char *item_name, unsigned int max_items,
nb_item = 0;
value_ok = 0;
- for (i = 0; i < strnlen(str, STR_TOKEN_SIZE); i++) {
+ for (i = 0; i < strnlen(str, STR_MULTI_TOKEN_SIZE); i++) {
c = str[i];
if ((c >= '0') && (c <= '9')) {
@@ -3958,5 +3958,5 @@ struct cmd_set_list_result {
cmdline_fixed_string_t cmd_keyword;
cmdline_fixed_string_t list_name;
- cmdline_fixed_string_t list_of_items;
+ cmdline_multi_string_t list_of_items;
};
@@ -4007,5 +4007,5 @@ static cmdline_parse_token_string_t cmd_set_list_name =
static cmdline_parse_token_string_t cmd_set_list_of_items =
TOKEN_STRING_INITIALIZER(struct cmd_set_list_result, list_of_items,
- NULL);
+ TOKEN_STRING_MULTI);
static cmdline_parse_inst_t cmd_set_fwd_list = {
--
2.51.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-10-31 13:53:52.803531977 +0000
+++ 0017-app-testpmd-increase-size-of-set-cores-list-command.patch 2025-10-31 13:53:52.034523362 +0000
@@ -1 +1 @@
-From d0f4f0779898e41a940e9a6f83f782750ffbfbb7 Mon Sep 17 00:00:00 2001
+From 7901aecec7ab5c2397b28f4eebc1e86a67e690d6 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit d0f4f0779898e41a940e9a6f83f782750ffbfbb7 ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index 7b4e27eddf..801dee4456 100644
+index e92dd9eade..79f8b4fad4 100644
@@ -23 +24 @@
-@@ -4064,5 +4064,5 @@ parse_item_list(const char *str, const char *item_name, unsigned int max_items,
+@@ -3907,5 +3907,5 @@ parse_item_list(const char *str, const char *item_name, unsigned int max_items,
@@ -30 +31 @@
-@@ -4115,5 +4115,5 @@ struct cmd_set_list_result {
+@@ -3958,5 +3958,5 @@ struct cmd_set_list_result {
@@ -37 +38 @@
-@@ -4164,5 +4164,5 @@ static cmdline_parse_token_string_t cmd_set_list_name =
+@@ -4007,5 +4007,5 @@ static cmdline_parse_token_string_t cmd_set_list_name =
More information about the stable
mailing list