patch 'app/testpmd: fix mask in flow random item' has been queued to stable release 24.11.4

[Kevin Traynor]

Hi,

FYI, your patch has been queued to stable release 24.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/05/25. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/6bc6f0786b0346521dea67fcb3e03b45ba70d054

Thanks.

Kevin

---
>From 6bc6f0786b0346521dea67fcb3e03b45ba70d054 Mon Sep 17 00:00:00 2001
From: Maayan Kashani <mkashani at nvidia.com>
Date: Wed, 30 Jul 2025 14:32:43 +0300
Subject: [PATCH] app/testpmd: fix mask in flow random item

[ upstream commit e3054b2f402f52c744344a4ec2a17ff1eb47f8e0 ]

A previous patch addressing an ASAN global-buffer-overflow issue
inadvertently degraded the random mask value translation.
Specifically, changing the mask from 0xffff to 0x0000ffff caused
the value to be shifted left by 16 bits, since Testpmd
defines arg::mask as a byte array.

Independent of the ASAN fix, the random item mask specification
was invalid at the API level: random items require a 32-bit mask,
but only a 16-bit mask was being used.

The correct mask for this use case is 0xffffffff.
This fix restores the correct random value translation
by applying the proper 32-bit mask and
addresses the original ASAN issue.

Fixes: 9a18070e3fe4 ("app/testpmd: fix flow random item token")

Signed-off-by: Maayan Kashani <mkashani at nvidia.com>
Acked-by: Dariusz Sosnowski <dsosnowski at nvidia.com>
---
 app/test-pmd/cmdline_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index eb26333759..c5ae8300d6 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -5583,5 +5583,5 @@ static const struct token token_list[] = {
 			     item_param),
 		.args = ARGS(ARGS_ENTRY_MASK(struct rte_flow_item_random,
-					     value, "\x00\x00\xff\xff")),
+					     value, "\xff\xff\xff\xff")),
 	},
 	[ITEM_GRE_KEY] = {
-- 
2.51.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2025-10-31 13:53:52.978476792 +0000
+++ 0023-app-testpmd-fix-mask-in-flow-random-item.patch	2025-10-31 13:53:52.048523406 +0000
@@ -1 +1 @@
-From e3054b2f402f52c744344a4ec2a17ff1eb47f8e0 Mon Sep 17 00:00:00 2001
+From 6bc6f0786b0346521dea67fcb3e03b45ba70d054 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit e3054b2f402f52c744344a4ec2a17ff1eb47f8e0 ]
+
@@ -22 +23,0 @@
-Cc: stable at dpdk.org
@@ -31 +32 @@
-index 83d398f8ee..38e751f3f3 100644
+index eb26333759..c5ae8300d6 100644
@@ -34 +35 @@
-@@ -5592,5 +5592,5 @@ static const struct token token_list[] = {
+@@ -5583,5 +5583,5 @@ static const struct token token_list[] = {