patch 'net/mlx5: fix use after scope of RSS configuration' has been queued to stable release 24.11.4

[Kevin Traynor]

Hi,

FYI, your patch has been queued to stable release 24.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/05/25. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/b77323ec4ad783ac997dc630c38c0d175a71f8fc

Thanks.

Kevin

---
>From b77323ec4ad783ac997dc630c38c0d175a71f8fc Mon Sep 17 00:00:00 2001
From: Maayan Kashani <mkashani at nvidia.com>
Date: Tue, 5 Aug 2025 16:20:57 +0300
Subject: [PATCH] net/mlx5: fix use after scope of RSS configuration

[ upstream commit b7dedd019a034331fbc67b1d10d59bf3531b5048 ]

This patch addresses AddressSanitizer (ASan) stack-use-after-scope
issues occurring during RSS flow creation in the MLX5 driver.
The root cause stemmed from the use of compound literals to
initialize flow action configurations, which could result in
pointers to temporary stack memory being retained in flow structures.
When these pointers were later accessed during flow conversion,
the underlying stack memory was no longer valid,
leading to ASAN-detected errors.

Modifications:
In mlx5_hw_rss_ptype_create_base_flow(),
the struct rte_flow_action_jump is now constructed
at the start of the function, rather than within the do statement.
This ensures a persistent stack allocation for the structure,
preventing use-after-scope situations.

This change eliminates the following ASan errors:
stack-use-after-scope reported in rte_flow_conv_copy

Fixes: ae67e3c43dd5 ("net/mlx5: support RSS expansion in non-template HWS setup")

Signed-off-by: Maayan Kashani <mkashani at nvidia.com>
Acked-by: Dariusz Sosnowski <dsosnowski at nvidia.com>
---
 drivers/net/mlx5/mlx5_nta_rss.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_nta_rss.c b/drivers/net/mlx5/mlx5_nta_rss.c
index 602df301ac..781eaf5e99 100644
--- a/drivers/net/mlx5/mlx5_nta_rss.c
+++ b/drivers/net/mlx5/mlx5_nta_rss.c
@@ -320,4 +320,7 @@ mlx5_hw_rss_ptype_create_base_flow(struct rte_eth_dev *dev,
 	struct rte_flow_action actions[MLX5_HW_MAX_ACTS];
 	enum mlx5_indirect_type indirect_type;
+	const struct rte_flow_action_jump jump_conf = {
+		.group = ptype_group
+	};
 
 	do {
@@ -334,7 +337,5 @@ mlx5_hw_rss_ptype_create_base_flow(struct rte_eth_dev *dev,
 		case RTE_FLOW_ACTION_TYPE_RSS:
 			actions[i].type = RTE_FLOW_ACTION_TYPE_JUMP;
-			actions[i].conf = &(const struct rte_flow_action_jump) {
-				.group = ptype_group
-			};
+			actions[i].conf = &jump_conf;
 			break;
 		default:
-- 
2.51.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2025-10-31 13:53:53.310006072 +0000
+++ 0034-net-mlx5-fix-use-after-scope-of-RSS-configuration.patch	2025-10-31 13:53:52.079523502 +0000
@@ -1 +1 @@
-From b7dedd019a034331fbc67b1d10d59bf3531b5048 Mon Sep 17 00:00:00 2001
+From b77323ec4ad783ac997dc630c38c0d175a71f8fc Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit b7dedd019a034331fbc67b1d10d59bf3531b5048 ]
+
@@ -26 +27,0 @@
-Cc: stable at dpdk.org
@@ -35 +36 @@
-index 8f00510445..1d2940a370 100644
+index 602df301ac..781eaf5e99 100644
@@ -38 +39 @@
-@@ -321,4 +321,7 @@ mlx5_hw_rss_ptype_create_base_flow(struct rte_eth_dev *dev,
+@@ -320,4 +320,7 @@ mlx5_hw_rss_ptype_create_base_flow(struct rte_eth_dev *dev,
@@ -46 +47 @@
-@@ -335,7 +338,5 @@ mlx5_hw_rss_ptype_create_base_flow(struct rte_eth_dev *dev,
+@@ -334,7 +337,5 @@ mlx5_hw_rss_ptype_create_base_flow(struct rte_eth_dev *dev,