patch 'net/iavf: fix Tx vector path selection logic' has been queued to stable release 24.11.4
Kevin Traynor
ktraynor at redhat.com
Fri Oct 31 15:32:46 CET 2025
Hi,
FYI, your patch has been queued to stable release 24.11.4
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/05/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/65960ba2bcfa95c69dd96a921a690cf932617065
Thanks.
Kevin
---
>From 65960ba2bcfa95c69dd96a921a690cf932617065 Mon Sep 17 00:00:00 2001
From: Ciara Loftus <ciara.loftus at intel.com>
Date: Thu, 19 Jun 2025 13:36:57 +0000
Subject: [PATCH] net/iavf: fix Tx vector path selection logic
[ upstream commit ecdccc79cf3296bb3cb6d53d87ad85d13828677b ]
Prior to this change, it was possible the scalar path would be selected
even if the AVX-512 path was available. This was due to the ordering of
the logic in the iavf_set_tx_function function. Support for all three
vector paths (sse, AVX2 and AVX-512) was first established and then in
that order, the tx_burst_type was set to the appropriate type. If all
three paths were supported, then the burst type would be first set to
sse, then AVX2 then AVX-512. However, in the AVX2 logic, if an error
was encountered then the burst type was set to a fallback option of the
scalar path. This is not desired behaviour because the AVX-512 path
should be selected over the scalar path when it is available.
This commit fixes this issue by only checking for AVX2 support after
deeming that AVX-512 is not supported.
Fixes: 77b19d1d4b2e ("net/iavf: fix mbuf release path selection")
Signed-off-by: Ciara Loftus <ciara.loftus at intel.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
drivers/net/iavf/iavf_rxtx.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index 0ffb9762fe..cce4917a3f 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -4163,8 +4163,4 @@ iavf_set_tx_function(struct rte_eth_dev *dev)
use_sse = true;
}
- if ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 ||
- rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1) &&
- rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_256)
- use_avx2 = true;
#ifdef CC_AVX512_SUPPORT
if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1 &&
@@ -4173,4 +4169,8 @@ iavf_set_tx_function(struct rte_eth_dev *dev)
use_avx512 = true;
#endif
+ if (!use_avx512 && (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 ||
+ rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1) &&
+ rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_256)
+ use_avx2 = true;
if (!use_sse && !use_avx2 && !use_avx512)
--
2.51.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-10-31 13:53:53.651769346 +0000
+++ 0044-net-iavf-fix-Tx-vector-path-selection-logic.patch 2025-10-31 13:53:52.142523699 +0000
@@ -1 +1 @@
-From ecdccc79cf3296bb3cb6d53d87ad85d13828677b Mon Sep 17 00:00:00 2001
+From 65960ba2bcfa95c69dd96a921a690cf932617065 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit ecdccc79cf3296bb3cb6d53d87ad85d13828677b ]
+
@@ -21 +22,0 @@
-Cc: stable at dpdk.org
@@ -26 +27 @@
- drivers/net/intel/iavf/iavf_rxtx.c | 8 ++++----
+ drivers/net/iavf/iavf_rxtx.c | 8 ++++----
@@ -29,5 +30,5 @@
-diff --git a/drivers/net/intel/iavf/iavf_rxtx.c b/drivers/net/intel/iavf/iavf_rxtx.c
-index 740876756b..5f5e3f047a 100644
---- a/drivers/net/intel/iavf/iavf_rxtx.c
-+++ b/drivers/net/intel/iavf/iavf_rxtx.c
-@@ -4228,8 +4228,4 @@ iavf_set_tx_function(struct rte_eth_dev *dev)
+diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
+index 0ffb9762fe..cce4917a3f 100644
+--- a/drivers/net/iavf/iavf_rxtx.c
++++ b/drivers/net/iavf/iavf_rxtx.c
+@@ -4163,8 +4163,4 @@ iavf_set_tx_function(struct rte_eth_dev *dev)
@@ -42 +43 @@
-@@ -4238,4 +4234,8 @@ iavf_set_tx_function(struct rte_eth_dev *dev)
+@@ -4173,4 +4169,8 @@ iavf_set_tx_function(struct rte_eth_dev *dev)
More information about the stable
mailing list