patch 'test/func_reentrancy: fix args to EAL init call' has been queued to stable release 24.11.4
Kevin Traynor
ktraynor at redhat.com
Fri Oct 31 15:33:12 CET 2025
Hi,
FYI, your patch has been queued to stable release 24.11.4
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/05/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/5f27e5e9f8df35ad145c64e9b5abd86c75d794e8
Thanks.
Kevin
---
>From 5f27e5e9f8df35ad145c64e9b5abd86c75d794e8 Mon Sep 17 00:00:00 2001
From: Bruce Richardson <bruce.richardson at intel.com>
Date: Thu, 9 Oct 2025 14:00:37 +0100
Subject: [PATCH] test/func_reentrancy: fix args to EAL init call
[ upstream commit b74d638ab9a769ed9628d2759029d2d20a081637 ]
The unit test for EAL init was passing in a NULL argv[0] value which is
invalid. Update to have a valid string for argv[0].
Fixes: 104a92bd026f ("app: add reentrancy tests")
Fixes: 978ead0144c1 ("test/func_reentrancy: fix EAL init call")
Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
Reviewed-by: David Marchand <david.marchand at redhat.com>
Acked-by: Chengwen Feng <fengchengwen at huawei.com>
---
app/test/test_func_reentrancy.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/app/test/test_func_reentrancy.c b/app/test/test_func_reentrancy.c
index 34d685d493..51e3069611 100644
--- a/app/test/test_func_reentrancy.c
+++ b/app/test/test_func_reentrancy.c
@@ -69,5 +69,7 @@ static int
test_eal_init_once(__rte_unused void *arg)
{
+ char appname[] = __FILE__;
unsigned lcore_self = rte_lcore_id();
+ char *argv[] = { appname, NULL };
WAIT_SYNCHRO_FOR_WORKERS();
@@ -75,5 +77,5 @@ test_eal_init_once(__rte_unused void *arg)
/* silent the check in the caller */
rte_atomic_store_explicit(&obj_count, 1, rte_memory_order_relaxed);
- if (rte_eal_init(0, NULL) != -1)
+ if (rte_eal_init(RTE_DIM(argv) - 1, argv) != -1)
return -1;
--
2.51.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-10-31 13:53:54.382415434 +0000
+++ 0070-test-func_reentrancy-fix-args-to-EAL-init-call.patch 2025-10-31 13:53:52.174121116 +0000
@@ -1 +1 @@
-From b74d638ab9a769ed9628d2759029d2d20a081637 Mon Sep 17 00:00:00 2001
+From 5f27e5e9f8df35ad145c64e9b5abd86c75d794e8 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit b74d638ab9a769ed9628d2759029d2d20a081637 ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -17,2 +18,2 @@
- app/test/test_func_reentrancy.c | 5 +++--
- 1 file changed, 3 insertions(+), 2 deletions(-)
+ app/test/test_func_reentrancy.c | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
@@ -21 +22 @@
-index f4c6cbc548..51e3069611 100644
+index 34d685d493..51e3069611 100644
@@ -24,5 +25,2 @@
-@@ -67,8 +67,9 @@ static RTE_ATOMIC(uint32_t) synchro;
- */
- static int
--test_eal_init_once(void *arg)
-+test_eal_init_once(__rte_unused void *arg)
+@@ -69,5 +69,7 @@ static int
+ test_eal_init_once(__rte_unused void *arg)
@@ -32 +29,0 @@
-- char *argv[] = { arg, NULL };
@@ -35,0 +33,7 @@
+@@ -75,5 +77,5 @@ test_eal_init_once(__rte_unused void *arg)
+ /* silent the check in the caller */
+ rte_atomic_store_explicit(&obj_count, 1, rte_memory_order_relaxed);
+- if (rte_eal_init(0, NULL) != -1)
++ if (rte_eal_init(RTE_DIM(argv) - 1, argv) != -1)
+ return -1;
+
More information about the stable
mailing list