patch 'net/bnxt: fix free of not allocated object' has been queued to stable release 24.11.4

[Kevin Traynor]

Hi,

FYI, your patch has been queued to stable release 24.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/05/25. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/d1f013cf64c22a8ff354f79b2ce4ef4875418b3d

Thanks.

Kevin

---
>From d1f013cf64c22a8ff354f79b2ce4ef4875418b3d Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Wed, 21 May 2025 12:37:27 -0700
Subject: [PATCH] net/bnxt: fix free of not allocated object

[ upstream commit 49b1673ec6693a673b4dc07984023f481cce4d96 ]

This was found as error when compiling with LTO.
The function allocates new data with rte_zmalloc and then
stores pointer in the pointer-to-pointer passed as argument.
In the unwind case, it would call rte_free() with wrong one.

Fixes: 80317ff6adfd ("net/bnxt/tf_core: support Thor2")

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
 drivers/net/bnxt/tf_core/v3/tfo.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/net/bnxt/tf_core/v3/tfo.c b/drivers/net/bnxt/tf_core/v3/tfo.c
index bee813ebf6..c888dd1e4e 100644
--- a/drivers/net/bnxt/tf_core/v3/tfo.c
+++ b/drivers/net/bnxt/tf_core/v3/tfo.c
@@ -75,7 +75,5 @@ void tfo_open(void **tfo, bool is_pf)
 	if (rc) {
 		PMD_DRV_LOG_LINE(ERR, "MPC bind failed");
-		rte_free(tfco);
-		*tfo = NULL;
-		return;
+		goto cleanup;
 	}
 	if (is_pf) {
@@ -105,6 +103,6 @@ void tfo_open(void **tfo, bool is_pf)
 
  cleanup:
-	if (tfco != NULL)
-		rte_free(tfo);
+	rte_free(tfco);
+	*tfo = NULL;
 }
 
-- 
2.51.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2025-10-31 13:53:54.573632449 +0000
+++ 0077-net-bnxt-fix-free-of-not-allocated-object.patch	2025-10-31 13:53:52.179400188 +0000
@@ -1 +1 @@
-From 49b1673ec6693a673b4dc07984023f481cce4d96 Mon Sep 17 00:00:00 2001
+From d1f013cf64c22a8ff354f79b2ce4ef4875418b3d Mon Sep 17 00:00:00 2001
@@ -4,0 +5,2 @@
+
+[ upstream commit 49b1673ec6693a673b4dc07984023f481cce4d96 ]