patch 'net/mlx5: fix leak of flow indexed pools' has been queued to stable release 24.11.4
Kevin Traynor
ktraynor at redhat.com
Fri Oct 31 15:33:32 CET 2025
Hi,
FYI, your patch has been queued to stable release 24.11.4
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/05/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/76f38fb1bba87bf15169ec4c16f1d86f5b89188c
Thanks.
Kevin
---
>From 76f38fb1bba87bf15169ec4c16f1d86f5b89188c Mon Sep 17 00:00:00 2001
From: Roi Dayan <roid at nvidia.com>
Date: Sun, 5 Oct 2025 10:23:45 +0300
Subject: [PATCH] net/mlx5: fix leak of flow indexed pools
[ upstream commit eefec46eeb89672815afd6c2497d21b928d77c54 ]
The cited commit allocated indexed pools but those pools
were never released. Fix it.
Fixes: b4edeaf3efd5 ("net/mlx5: replace flow list with indexed pool")
Signed-off-by: Roi Dayan <roid at nvidia.com>
Acked-by: Bing Zhao <bingz at nvidia.com>
---
.mailmap | 1 +
drivers/net/mlx5/mlx5.c | 13 +++++++++++++
2 files changed, 14 insertions(+)
diff --git a/.mailmap b/.mailmap
index b0c4217927..5e3d447103 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1315,4 +1315,5 @@ Rogelio Domínguez Hernández <rogelio.dominguez at gmail.com>
Roger Melton <rmelton at cisco.com>
Rohit Raj <rohit.raj at nxp.com>
+Roi Dayan <roid at nvidia.com>
Roland Qi <roland.qi at ucloud.cn>
Rolf Neugebauer <rolf.neugebauer at netronome.com>
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 96269d4e8e..0580e5d030 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -2307,4 +2307,16 @@ mlx5_proc_priv_uninit(struct rte_eth_dev *dev)
}
+static void
+mlx5_flow_pools_destroy(struct mlx5_priv *priv)
+{
+ int i;
+
+ for (i = 0; i < MLX5_FLOW_TYPE_MAXI; i++) {
+ if (!priv->flows[i])
+ continue;
+ mlx5_ipool_destroy(priv->flows[i]);
+ }
+}
+
/**
* DPDK callback to close the device.
@@ -2502,4 +2514,5 @@ mlx5_dev_close(struct rte_eth_dev *dev)
claim_zero(rte_eth_switch_domain_free(priv->domain_id));
}
+ mlx5_flow_pools_destroy(priv);
memset(priv, 0, sizeof(*priv));
priv->domain_id = RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID;
--
2.51.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-10-31 13:53:54.985486559 +0000
+++ 0090-net-mlx5-fix-leak-of-flow-indexed-pools.patch 2025-10-31 13:53:52.253524046 +0000
@@ -1 +1 @@
-From eefec46eeb89672815afd6c2497d21b928d77c54 Mon Sep 17 00:00:00 2001
+From 76f38fb1bba87bf15169ec4c16f1d86f5b89188c Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit eefec46eeb89672815afd6c2497d21b928d77c54 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index aef57a4c32..ff13bf09fb 100644
+index b0c4217927..5e3d447103 100644
@@ -23 +24 @@
-@@ -1362,4 +1362,5 @@ Rogelio Domínguez Hernández <rogelio.dominguez at gmail.com>
+@@ -1315,4 +1315,5 @@ Rogelio Domínguez Hernández <rogelio.dominguez at gmail.com>
@@ -30 +31 @@
-index ece29fb216..b018a4f0e2 100644
+index 96269d4e8e..0580e5d030 100644
@@ -33 +34 @@
-@@ -2319,4 +2319,16 @@ mlx5_proc_priv_uninit(struct rte_eth_dev *dev)
+@@ -2307,4 +2307,16 @@ mlx5_proc_priv_uninit(struct rte_eth_dev *dev)
@@ -50 +51 @@
-@@ -2508,4 +2520,5 @@ mlx5_dev_close(struct rte_eth_dev *dev)
+@@ -2502,4 +2514,5 @@ mlx5_dev_close(struct rte_eth_dev *dev)
More information about the stable
mailing list