patch 'net/dpaa2: fix queue block memory leak on port close' has been queued to stable release 25.11.1

Kevin Traynor ktraynor at redhat.com
Wed Apr 1 13:56:42 CEST 2026


Hi,

FYI, your patch has been queued to stable release 25.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/03/26. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/d0e7ee8e01fee1fee7ee7a579cc6ef0fd78c1c5f

Thanks.

Kevin

---
>From d0e7ee8e01fee1fee7ee7a579cc6ef0fd78c1c5f Mon Sep 17 00:00:00 2001
From: Maxime Leroy <maxime at leroys.fr>
Date: Wed, 25 Mar 2026 21:45:28 +0100
Subject: [PATCH] net/dpaa2: fix queue block memory leak on port close
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

[ upstream commit acc78825a671d21e687a717c774f52dceea4dec3 ]

Commit 46d02eeaaeb8 ("net/dpaa2: fix queue freeing") added
priv->rx_vq[i] = NULL inside the cleanup loop. This NULLs rx_vq[0]
on the first iteration, so the subsequent rte_free(priv->rx_vq[0])
becomes rte_free(NULL) — a no-op — leaking the entire mc_q block
(all RX + TX + TX conf queue structs) on every port close.

Save the base pointer before the loop and free that instead.

Fixes: 46d02eeaaeb8 ("net/dpaa2: fix queue freeing")

Signed-off-by: Maxime Leroy <maxime at leroys.fr>
Acked-by: Hemant Agrawal <hemant.agrawal at nxp.com>
---
 drivers/net/dpaa2/dpaa2_ethdev.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index fdf3e0f220..9f8aca19f2 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -664,4 +664,7 @@ dpaa2_free_rx_tx_queues(struct rte_eth_dev *dev)
 	/* Queue allocation base */
 	if (priv->rx_vq[0]) {
+		/* Save base pointer before the loop NULLs rx_vq[] entries */
+		void *mc_q = priv->rx_vq[0];
+
 		/* cleaning up queue storage */
 		for (i = 0; i < priv->nb_rx_queues; i++) {
@@ -694,6 +697,5 @@ dpaa2_free_rx_tx_queues(struct rte_eth_dev *dev)
 
 		/*free memory for all queues (RX+TX) */
-		rte_free(priv->rx_vq[0]);
-		priv->rx_vq[0] = NULL;
+		rte_free(mc_q);
 	}
 }
-- 
2.53.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2026-04-01 12:56:52.133450932 +0100
+++ 0004-net-dpaa2-fix-queue-block-memory-leak-on-port-close.patch	2026-04-01 12:56:52.008524077 +0100
@@ -1 +1 @@
-From acc78825a671d21e687a717c774f52dceea4dec3 Mon Sep 17 00:00:00 2001
+From d0e7ee8e01fee1fee7ee7a579cc6ef0fd78c1c5f Mon Sep 17 00:00:00 2001
@@ -8,0 +9,2 @@
+[ upstream commit acc78825a671d21e687a717c774f52dceea4dec3 ]
+
@@ -18 +19,0 @@
-Cc: stable at dpdk.org
@@ -27 +28 @@
-index b3a79f18d3..cef819650b 100644
+index fdf3e0f220..9f8aca19f2 100644
@@ -30 +31 @@
-@@ -662,4 +662,7 @@ dpaa2_free_rx_tx_queues(struct rte_eth_dev *dev)
+@@ -664,4 +664,7 @@ dpaa2_free_rx_tx_queues(struct rte_eth_dev *dev)
@@ -38 +39 @@
-@@ -692,6 +695,5 @@ dpaa2_free_rx_tx_queues(struct rte_eth_dev *dev)
+@@ -694,6 +697,5 @@ dpaa2_free_rx_tx_queues(struct rte_eth_dev *dev)



More information about the stable mailing list