patch 'net/mana: fix fast-path ops setup in secondary process' has been queued to stable release 23.11.7
Shani Peretz
shperetz at nvidia.com
Wed Apr 15 11:59:34 CEST 2026
Hi,
FYI, your patch has been queued to stable release 23.11.7
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/19/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/shanipr/dpdk-stable
This queued commit can be viewed at:
https://github.com/shanipr/dpdk-stable/commit/7d14ae13895ba225d19a84b7ee61753486d0d219
Thanks.
Shani
---
>From 7d14ae13895ba225d19a84b7ee61753486d0d219 Mon Sep 17 00:00:00 2001
From: Long Li <longli at microsoft.com>
Date: Thu, 26 Feb 2026 17:59:25 -0800
Subject: [PATCH] net/mana: fix fast-path ops setup in secondary process
[ upstream commit a5d0e9f61c30127af637bf68838f8ac1dd5aecdf ]
On hotplug, the secondary process is not able to set rte_eth_fp_ops
because the primary process has not finished setting up the device
for datapath.
Fix this by properly setting up rte_eth_fp_ops in the secondary
process when the primary requests to start datapath. Set both
rxq.data and txq.data to point to the device's RX/TX queue arrays,
enabling the fast-path operations to access queues correctly.
Also update rte_eth_fp_ops burst function pointers in the STOP_RXTX
handler. Without this, the secondary's rte_eth_fp_ops retains stale
burst function pointers after stop, since rte_eth_fp_ops is
process-local and eth_dev_fp_ops_reset() in rte_eth_dev_stop() only
affects the primary.
Without this fix, the secondary process cannot transmit or receive
packets because the fast-path queue data pointers are NULL.
Fixes: 37544700e1db ("net/mana: start/stop device")
Signed-off-by: Long Li <longli at microsoft.com>
---
drivers/net/mana/mp.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/net/mana/mp.c b/drivers/net/mana/mp.c
index 3d0aa0d493..669ec6b93b 100644
--- a/drivers/net/mana/mp.c
+++ b/drivers/net/mana/mp.c
@@ -144,6 +144,11 @@ mana_mp_secondary_handle(const struct rte_mp_msg *mp_msg, const void *peer)
dev->tx_pkt_burst = mana_tx_burst;
dev->rx_pkt_burst = mana_rx_burst;
+ rte_eth_fp_ops[param->port_id].rx_pkt_burst = mana_rx_burst;
+ rte_eth_fp_ops[param->port_id].tx_pkt_burst = mana_tx_burst;
+ rte_eth_fp_ops[param->port_id].rxq.data = dev->data->rx_queues;
+ rte_eth_fp_ops[param->port_id].txq.data = dev->data->tx_queues;
+
rte_mb();
res->result = 0;
@@ -153,6 +158,9 @@ mana_mp_secondary_handle(const struct rte_mp_msg *mp_msg, const void *peer)
case MANA_MP_REQ_STOP_RXTX:
DRV_LOG(INFO, "Port %u stopping datapath", dev->data->port_id);
+ rte_eth_fp_ops[param->port_id].rx_pkt_burst = mana_rx_burst_removed;
+ rte_eth_fp_ops[param->port_id].tx_pkt_burst = mana_tx_burst_removed;
+
dev->tx_pkt_burst = mana_tx_burst_removed;
dev->rx_pkt_burst = mana_rx_burst_removed;
--
2.43.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-04-14 14:44:32.115613567 +0300
+++ 0033-net-mana-fix-fast-path-ops-setup-in-secondary-proces.patch 2026-04-14 14:44:28.565551000 +0300
@@ -1 +1 @@
-From a5d0e9f61c30127af637bf68838f8ac1dd5aecdf Mon Sep 17 00:00:00 2001
+From 7d14ae13895ba225d19a84b7ee61753486d0d219 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit a5d0e9f61c30127af637bf68838f8ac1dd5aecdf ]
+
@@ -25 +26,0 @@
-Cc: stable at dpdk.org
@@ -33 +34 @@
-index 5467d385ce..72417fc0c7 100644
+index 3d0aa0d493..669ec6b93b 100644
@@ -36 +37 @@
-@@ -145,6 +145,11 @@ mana_mp_secondary_handle(const struct rte_mp_msg *mp_msg, const void *peer)
+@@ -144,6 +144,11 @@ mana_mp_secondary_handle(const struct rte_mp_msg *mp_msg, const void *peer)
@@ -48 +49 @@
-@@ -154,6 +159,9 @@ mana_mp_secondary_handle(const struct rte_mp_msg *mp_msg, const void *peer)
+@@ -153,6 +158,9 @@ mana_mp_secondary_handle(const struct rte_mp_msg *mp_msg, const void *peer)
More information about the stable
mailing list