patch 'net/dpaa2: fix resource leak on soft parser failure' has been queued to stable release 23.11.7
Shani Peretz
shperetz at nvidia.com
Wed Apr 15 12:00:25 CEST 2026
Hi,
FYI, your patch has been queued to stable release 23.11.7
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/19/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/shanipr/dpdk-stable
This queued commit can be viewed at:
https://github.com/shanipr/dpdk-stable/commit/3710ac4debe9d79f247ad415edb93bffd160d9f1
Thanks.
Shani
---
>From 3710ac4debe9d79f247ad415edb93bffd160d9f1 Mon Sep 17 00:00:00 2001
From: Maxime Leroy <maxime at leroys.fr>
Date: Wed, 25 Mar 2026 21:45:31 +0100
Subject: [PATCH] net/dpaa2: fix resource leak on soft parser failure
[ upstream commit ec7e017938f3f8dfaa5494bb26810e5803730e45 ]
When soft parser loading or enabling fails during probe, the error
path returns directly instead of going through the init_err label.
This skips dpaa2_dev_close() and leaks all resources allocated during
probe (queues, MAC addresses, extract params).
Fixes: 72ec7a678e70 ("net/dpaa2: add soft parser driver")
Signed-off-by: Maxime Leroy <maxime at leroys.fr>
Acked-by: Hemant Agrawal <hemant.agrawal at nxp.com>
---
drivers/net/dpaa2/dpaa2_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index 809abbe1e3..5a27584939 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -2844,7 +2844,7 @@ dpaa2_dev_init(struct rte_eth_dev *eth_dev)
if (ret < 0) {
DPAA2_PMD_ERR(" Error(%d) in loading softparser",
ret);
- return ret;
+ goto init_err;
}
ret = dpaa2_eth_enable_wriop_soft_parser(priv,
@@ -2852,7 +2852,7 @@ dpaa2_dev_init(struct rte_eth_dev *eth_dev)
if (ret < 0) {
DPAA2_PMD_ERR(" Error(%d) in enabling softparser",
ret);
- return ret;
+ goto init_err;
}
}
RTE_LOG(INFO, PMD, "%s: netdev created, connected to %s\n",
--
2.43.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-04-14 14:44:36.710032906 +0300
+++ 0084-net-dpaa2-fix-resource-leak-on-soft-parser-failure.patch 2026-04-14 14:44:28.866441000 +0300
@@ -1 +1 @@
-From ec7e017938f3f8dfaa5494bb26810e5803730e45 Mon Sep 17 00:00:00 2001
+From 3710ac4debe9d79f247ad415edb93bffd160d9f1 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit ec7e017938f3f8dfaa5494bb26810e5803730e45 ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -21 +22 @@
-index 605c75ad70..5e0a897ed3 100644
+index 809abbe1e3..5a27584939 100644
@@ -24 +25 @@
-@@ -3165,7 +3165,7 @@ dpaa2_dev_init(struct rte_eth_dev *eth_dev)
+@@ -2844,7 +2844,7 @@ dpaa2_dev_init(struct rte_eth_dev *eth_dev)
@@ -33 +34 @@
-@@ -3173,7 +3173,7 @@ dpaa2_dev_init(struct rte_eth_dev *eth_dev)
+@@ -2852,7 +2852,7 @@ dpaa2_dev_init(struct rte_eth_dev *eth_dev)
@@ -41 +42 @@
-
+ RTE_LOG(INFO, PMD, "%s: netdev created, connected to %s\n",
More information about the stable
mailing list