patch 'net/dpaa2: fix burst mode info' has been queued to stable release 23.11.7
Shani Peretz
shperetz at nvidia.com
Wed Apr 15 12:00:30 CEST 2026
Hi,
FYI, your patch has been queued to stable release 23.11.7
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/19/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/shanipr/dpdk-stable
This queued commit can be viewed at:
https://github.com/shanipr/dpdk-stable/commit/2d9c56d4fab04005e028000ce18a35f450940db4
Thanks.
Shani
---
>From 2d9c56d4fab04005e028000ce18a35f450940db4 Mon Sep 17 00:00:00 2001
From: Maxime Leroy <maxime at leroys.fr>
Date: Wed, 25 Mar 2026 21:45:39 +0100
Subject: [PATCH] net/dpaa2: fix burst mode info
[ upstream commit a86fd775331c166d3fd2b3c19bf634e42d319eb1 ]
The burst_mode_get functions were incorrectly listing configured
offload flags instead of reporting the active burst function, unlike
every other PMD (i40e, mlx5, ixgbe, hns3) which match on the burst
function pointer. On top of that, snprintf + break meant only the
first matching offload was ever shown.
Rewrite both functions to match on the actual rx_pkt_burst/tx_pkt_burst
function pointer, consistent with the rest of the codebase.
Not tested, found by code review.
Fixes: ddbc2b6658d0 ("net/dpaa2: add Tx/Rx burst mode info")
Reported-by: Stephen Hemminger <stephen at networkplumber.org>
Signed-off-by: Maxime Leroy <maxime at leroys.fr>
Acked-by: Hemant Agrawal <hemant.agrawal at nxp.com>
---
drivers/net/dpaa2/dpaa2_ethdev.c | 76 +++++++++-----------------------
1 file changed, 22 insertions(+), 54 deletions(-)
diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index 8cc390a9bb..6fb216093c 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -293,34 +293,18 @@ dpaa2_dev_rx_burst_mode_get(struct rte_eth_dev *dev,
__rte_unused uint16_t queue_id,
struct rte_eth_burst_mode *mode)
{
- struct rte_eth_conf *eth_conf = &dev->data->dev_conf;
- int ret = -EINVAL;
- unsigned int i;
- const struct burst_info {
- uint64_t flags;
- const char *output;
- } rx_offload_map[] = {
- {RTE_ETH_RX_OFFLOAD_CHECKSUM, " Checksum,"},
- {RTE_ETH_RX_OFFLOAD_SCTP_CKSUM, " SCTP csum,"},
- {RTE_ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM, " Outer IPV4 csum,"},
- {RTE_ETH_RX_OFFLOAD_OUTER_UDP_CKSUM, " Outer UDP csum,"},
- {RTE_ETH_RX_OFFLOAD_VLAN_STRIP, " VLAN strip,"},
- {RTE_ETH_RX_OFFLOAD_VLAN_FILTER, " VLAN filter,"},
- {RTE_ETH_RX_OFFLOAD_TIMESTAMP, " Timestamp,"},
- {RTE_ETH_RX_OFFLOAD_RSS_HASH, " RSS,"},
- {RTE_ETH_RX_OFFLOAD_SCATTER, " Scattered,"}
- };
+ eth_rx_burst_t pkt_burst = dev->rx_pkt_burst;
+
+ if (pkt_burst == dpaa2_dev_prefetch_rx)
+ snprintf(mode->info, sizeof(mode->info), "%s", "Scalar Prefetch");
+ else if (pkt_burst == dpaa2_dev_rx)
+ snprintf(mode->info, sizeof(mode->info), "%s", "Scalar");
+ else if (pkt_burst == dpaa2_dev_loopback_rx)
+ snprintf(mode->info, sizeof(mode->info), "%s", "Loopback");
+ else
+ return -EINVAL;
- /* Update Rx offload info */
- for (i = 0; i < RTE_DIM(rx_offload_map); i++) {
- if (eth_conf->rxmode.offloads & rx_offload_map[i].flags) {
- snprintf(mode->info, sizeof(mode->info), "%s",
- rx_offload_map[i].output);
- ret = 0;
- break;
- }
- }
- return ret;
+ return 0;
}
static int
@@ -328,34 +312,18 @@ dpaa2_dev_tx_burst_mode_get(struct rte_eth_dev *dev,
__rte_unused uint16_t queue_id,
struct rte_eth_burst_mode *mode)
{
- struct rte_eth_conf *eth_conf = &dev->data->dev_conf;
- int ret = -EINVAL;
- unsigned int i;
- const struct burst_info {
- uint64_t flags;
- const char *output;
- } tx_offload_map[] = {
- {RTE_ETH_TX_OFFLOAD_VLAN_INSERT, " VLAN Insert,"},
- {RTE_ETH_TX_OFFLOAD_IPV4_CKSUM, " IPV4 csum,"},
- {RTE_ETH_TX_OFFLOAD_UDP_CKSUM, " UDP csum,"},
- {RTE_ETH_TX_OFFLOAD_TCP_CKSUM, " TCP csum,"},
- {RTE_ETH_TX_OFFLOAD_SCTP_CKSUM, " SCTP csum,"},
- {RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM, " Outer IPV4 csum,"},
- {RTE_ETH_TX_OFFLOAD_MT_LOCKFREE, " MT lockfree,"},
- {RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE, " MBUF free disable,"},
- {RTE_ETH_TX_OFFLOAD_MULTI_SEGS, " Scattered,"}
- };
+ eth_tx_burst_t pkt_burst = dev->tx_pkt_burst;
+
+ if (pkt_burst == dpaa2_dev_tx)
+ snprintf(mode->info, sizeof(mode->info), "%s", "Scalar");
+ else if (pkt_burst == dpaa2_dev_tx_ordered)
+ snprintf(mode->info, sizeof(mode->info), "%s", "Ordered");
+ else if (pkt_burst == rte_eth_pkt_burst_dummy)
+ snprintf(mode->info, sizeof(mode->info), "%s", "Dummy");
+ else
+ return -EINVAL;
- /* Update Tx offload info */
- for (i = 0; i < RTE_DIM(tx_offload_map); i++) {
- if (eth_conf->txmode.offloads & tx_offload_map[i].flags) {
- snprintf(mode->info, sizeof(mode->info), "%s",
- tx_offload_map[i].output);
- ret = 0;
- break;
- }
- }
- return ret;
+ return 0;
}
static int
--
2.43.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-04-14 14:44:37.147248505 +0300
+++ 0089-net-dpaa2-fix-burst-mode-info.patch 2026-04-14 14:44:28.892434000 +0300
@@ -1 +1 @@
-From a86fd775331c166d3fd2b3c19bf634e42d319eb1 Mon Sep 17 00:00:00 2001
+From 2d9c56d4fab04005e028000ce18a35f450940db4 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit a86fd775331c166d3fd2b3c19bf634e42d319eb1 ]
+
@@ -18 +19,0 @@
-Cc: stable at dpdk.org
@@ -28 +29 @@
-index cae81d3a20..18d8bf5444 100644
+index 8cc390a9bb..6fb216093c 100644
@@ -31,3 +32,3 @@
-@@ -443,34 +443,18 @@ dpaa2_dev_rx_burst_mode_get(struct rte_eth_dev *dev,
- __rte_unused uint16_t queue_id,
- struct rte_eth_burst_mode *mode)
+@@ -293,34 +293,18 @@ dpaa2_dev_rx_burst_mode_get(struct rte_eth_dev *dev,
+ __rte_unused uint16_t queue_id,
+ struct rte_eth_burst_mode *mode)
@@ -77 +78 @@
-@@ -478,34 +462,18 @@ dpaa2_dev_tx_burst_mode_get(struct rte_eth_dev *dev,
+@@ -328,34 +312,18 @@ dpaa2_dev_tx_burst_mode_get(struct rte_eth_dev *dev,
More information about the stable
mailing list