patch 'eventdev: fix variable shadowing' has been queued to stable release 24.11.5
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Fri Feb 20 15:55:10 CET 2026
Hi,
FYI, your patch has been queued to stable release 24.11.5
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/22/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/798940a09ff2e6ebcb781add96444f4e7a912dfa
Thanks.
Luca Boccassi
---
>From 798940a09ff2e6ebcb781add96444f4e7a912dfa Mon Sep 17 00:00:00 2001
From: Bruce Richardson <bruce.richardson at intel.com>
Date: Wed, 14 Jan 2026 15:44:18 +0000
Subject: [PATCH] eventdev: fix variable shadowing
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
[ upstream commit c45fb0fb48edb3eb88702c7aa00019d0756e7d52 ]
Rename a macro variable to avoid shadowing conflicts, and reduce the
scope of another variable for the same reason.
Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation")
Fixes: 7f33abd49b26 ("eventdev/eth_rx: support appropriately report idle")
Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
Acked-by: Stephen Hemminger <stephen at networkplumber.org>
Reviewed-by: Mattias Rönnblom <mattias.ronnblom at ericsson.com>
---
lib/eventdev/rte_event_eth_rx_adapter.c | 5 ++---
lib/eventdev/rte_event_eth_tx_adapter.c | 8 ++++----
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
index 39674c4604..b5a2c25bfc 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -1190,7 +1190,6 @@ rxa_intr_thread(void *arg)
static inline bool
rxa_intr_ring_dequeue(struct event_eth_rx_adapter *rx_adapter)
{
- uint32_t n;
uint32_t nb_rx = 0;
int rxq_empty;
struct eth_event_enqueue_buffer *buf;
@@ -1259,9 +1258,9 @@ rxa_intr_ring_dequeue(struct event_eth_rx_adapter *rx_adapter)
if (rxa_shared_intr(dev_info, queue)) {
uint16_t i;
uint16_t nb_queues;
+ uint32_t n = 0;
nb_queues = dev_info->dev->data->nb_rx_queues;
- n = 0;
for (i = dev_info->next_q_idx; i < nb_queues; i++) {
uint8_t enq_buffer_full;
@@ -1288,7 +1287,7 @@ rxa_intr_ring_dequeue(struct event_eth_rx_adapter *rx_adapter)
RTE_MAX_RXTX_INTR_VEC_ID - 1 :
0;
} else {
- n = rxa_eth_rx(rx_adapter, port, queue, nb_rx,
+ uint32_t n = rxa_eth_rx(rx_adapter, port, queue, nb_rx,
rx_adapter->max_nb_rx,
&rxq_empty, buf, stats);
rx_adapter->qd_valid = !rxq_empty;
diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
index 67fff8b7d6..d56225e49a 100644
--- a/lib/eventdev/rte_event_eth_tx_adapter.c
+++ b/lib/eventdev/rte_event_eth_tx_adapter.c
@@ -63,11 +63,11 @@ do { \
#define TXA_CHECK_OR_ERR_RET(id) \
do {\
- int ret; \
+ int _ret; \
RTE_EVENT_ETH_TX_ADAPTER_ID_VALID_OR_ERR_RET((id), -EINVAL); \
- ret = txa_init(); \
- if (ret != 0) \
- return ret; \
+ _ret = txa_init(); \
+ if (_ret != 0) \
+ return _ret; \
if (!txa_adapter_exist((id))) \
return -EINVAL; \
} while (0)
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-02-20 14:55:43.684932620 +0000
+++ 0008-eventdev-fix-variable-shadowing.patch 2026-02-20 14:55:43.160190328 +0000
@@ -1 +1 @@
-From c45fb0fb48edb3eb88702c7aa00019d0756e7d52 Mon Sep 17 00:00:00 2001
+From 798940a09ff2e6ebcb781add96444f4e7a912dfa Mon Sep 17 00:00:00 2001
@@ -8,0 +9,2 @@
+[ upstream commit c45fb0fb48edb3eb88702c7aa00019d0756e7d52 ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -25 +26 @@
-index 994f256322..d564e14b72 100644
+index 39674c4604..b5a2c25bfc 100644
@@ -28 +29 @@
-@@ -1191,7 +1191,6 @@ rxa_intr_thread(void *arg)
+@@ -1190,7 +1190,6 @@ rxa_intr_thread(void *arg)
@@ -36 +37 @@
-@@ -1260,9 +1259,9 @@ rxa_intr_ring_dequeue(struct event_eth_rx_adapter *rx_adapter)
+@@ -1259,9 +1258,9 @@ rxa_intr_ring_dequeue(struct event_eth_rx_adapter *rx_adapter)
@@ -47 +48 @@
-@@ -1289,7 +1288,7 @@ rxa_intr_ring_dequeue(struct event_eth_rx_adapter *rx_adapter)
+@@ -1288,7 +1287,7 @@ rxa_intr_ring_dequeue(struct event_eth_rx_adapter *rx_adapter)
@@ -57 +58 @@
-index 83b6af0955..91c7be55c7 100644
+index 67fff8b7d6..d56225e49a 100644
@@ -60 +61 @@
-@@ -64,11 +64,11 @@ do { \
+@@ -63,11 +63,11 @@ do { \
More information about the stable
mailing list