patch 'net/i40e: fix variable shadowing' has been queued to stable release 24.11.5
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Fri Feb 20 15:55:19 CET 2026
Hi,
FYI, your patch has been queued to stable release 24.11.5
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/22/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/e3f14260cc6b72532faa67454b21361d4d086880
Thanks.
Luca Boccassi
---
>From e3f14260cc6b72532faa67454b21361d4d086880 Mon Sep 17 00:00:00 2001
From: Bruce Richardson <bruce.richardson at intel.com>
Date: Wed, 14 Jan 2026 15:44:28 +0000
Subject: [PATCH] net/i40e: fix variable shadowing
[ upstream commit 7630aa3f5a7da4975d22f4f0e6c80bf895a09489 ]
The local variables defined with the I40E_WRITE_GLB_REG macro are
shadowing other variables. Rename the vars to start with "_" to avoid
this shadowing.
Fixes: 2bedd7277a10 ("net/i40e: print real global changes")
Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
Acked-by: Stephen Hemminger <stephen at networkplumber.org>
---
drivers/net/i40e/i40e_ethdev.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h
index 98213948b4..15df4c3302 100644
--- a/drivers/net/i40e/i40e_ethdev.h
+++ b/drivers/net/i40e/i40e_ethdev.h
@@ -91,11 +91,11 @@
#define I40E_WRITE_GLB_REG(hw, reg, value) \
do { \
uint32_t ori_val; \
- struct rte_eth_dev *dev; \
- struct rte_eth_dev_data *dev_data; \
+ struct rte_eth_dev *_dev; \
+ struct rte_eth_dev_data *_dev_data; \
ori_val = I40E_READ_REG((hw), (reg)); \
- dev_data = ((struct i40e_adapter *)hw->back)->pf.dev_data; \
- dev = &rte_eth_devices[dev_data->port_id]; \
+ _dev_data = ((struct i40e_adapter *)hw->back)->pf.dev_data; \
+ _dev = &rte_eth_devices[_dev_data->port_id]; \
I40E_PCI_REG_WRITE(I40E_PCI_REG_ADDR((hw), \
(reg)), (value)); \
if (ori_val != value) \
@@ -103,7 +103,7 @@
"i40e device %s changed global " \
"register [0x%08x]. original: 0x%08x, " \
"new: 0x%08x ", \
- (dev->device->name), (reg), \
+ (_dev->device->name), (reg), \
(ori_val), (value)); \
} while (0)
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-02-20 14:55:44.008441586 +0000
+++ 0017-net-i40e-fix-variable-shadowing.patch 2026-02-20 14:55:43.180190667 +0000
@@ -1 +1 @@
-From 7630aa3f5a7da4975d22f4f0e6c80bf895a09489 Mon Sep 17 00:00:00 2001
+From e3f14260cc6b72532faa67454b21361d4d086880 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 7630aa3f5a7da4975d22f4f0e6c80bf895a09489 ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -16 +17 @@
- drivers/net/intel/i40e/i40e_ethdev.h | 10 +++++-----
+ drivers/net/i40e/i40e_ethdev.h | 10 +++++-----
@@ -19,5 +20,5 @@
-diff --git a/drivers/net/intel/i40e/i40e_ethdev.h b/drivers/net/intel/i40e/i40e_ethdev.h
-index 3fca089d6c..70dc506037 100644
---- a/drivers/net/intel/i40e/i40e_ethdev.h
-+++ b/drivers/net/intel/i40e/i40e_ethdev.h
-@@ -92,11 +92,11 @@
+diff --git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h
+index 98213948b4..15df4c3302 100644
+--- a/drivers/net/i40e/i40e_ethdev.h
++++ b/drivers/net/i40e/i40e_ethdev.h
+@@ -91,11 +91,11 @@
@@ -39 +40 @@
-@@ -104,7 +104,7 @@
+@@ -103,7 +103,7 @@
More information about the stable
mailing list