patch 'net/sfc: drop AUTO from FEC capabilities and fix comment' has been queued to stable release 24.11.5
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Fri Feb 20 15:55:34 CET 2026
Hi,
FYI, your patch has been queued to stable release 24.11.5
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/22/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/928d341916e3a3c7340962749bcac39819abec13
Thanks.
Luca Boccassi
---
>From 928d341916e3a3c7340962749bcac39819abec13 Mon Sep 17 00:00:00 2001
From: Ivan Malov <ivan.malov at arknetworks.am>
Date: Tue, 30 Dec 2025 01:35:26 +0400
Subject: [PATCH] net/sfc: drop AUTO from FEC capabilities and fix comment
[ upstream commit a0d1eb6a4e1b8be4cd6209c1186d28ec373611de ]
AUTO is not a capability. It is rather a special value. Do not indicate it.
Also, improve the comment to explain this change and the overall principle.
Fixes: b526903f308e ("net/sfc: offer support for 200G link ability on new adaptors")
Fixes: 5efa8fc1cfc0 ("net/sfc: support FEC feature")
Signed-off-by: Ivan Malov <ivan.malov at arknetworks.am>
Reviewed-by: Andy Moreton <andy.moreton at amd.com>
---
drivers/net/sfc/sfc_ethdev.c | 28 +++++++++++++---------------
1 file changed, 13 insertions(+), 15 deletions(-)
diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index 52575c817a..d4e997bcef 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc/sfc_ethdev.c
@@ -2368,18 +2368,20 @@ sfc_fec_get_capa_speed_to_fec(uint32_t supported_caps,
rs = true;
/*
- * NOFEC and AUTO FEC modes are always supported.
- * FW does not provide information about the supported
- * FEC modes per the link speed.
- * Supported FEC depends on supported link speeds and
- * supported FEC modes by a device.
+ * NOFEC can always be requested, but if the link technology for the
+ * intended speed mandates FEC, doing so will not bring the link up.
+ *
+ * FW cannot report supported FEC modes per speed/link technology,
+ * so use best-effort approximation to fill in the capabilities.
+ *
+ * Do not indicate 'AUTO'. This bit is reserved for user
+ * input. It has nothing to do with capability reporting.
*/
if (supported_caps & (1u << EFX_PHY_CAP_10000FDX)) {
if (speed_fec_capa != NULL) {
speed_fec_capa[num].speed = RTE_ETH_SPEED_NUM_10G;
speed_fec_capa[num].capa =
- RTE_ETH_FEC_MODE_CAPA_MASK(NOFEC) |
- RTE_ETH_FEC_MODE_CAPA_MASK(AUTO);
+ RTE_ETH_FEC_MODE_CAPA_MASK(NOFEC);
if (baser) {
speed_fec_capa[num].capa |=
RTE_ETH_FEC_MODE_CAPA_MASK(BASER);
@@ -2391,8 +2393,7 @@ sfc_fec_get_capa_speed_to_fec(uint32_t supported_caps,
if (speed_fec_capa != NULL) {
speed_fec_capa[num].speed = RTE_ETH_SPEED_NUM_25G;
speed_fec_capa[num].capa =
- RTE_ETH_FEC_MODE_CAPA_MASK(NOFEC) |
- RTE_ETH_FEC_MODE_CAPA_MASK(AUTO);
+ RTE_ETH_FEC_MODE_CAPA_MASK(NOFEC);
if (baser) {
speed_fec_capa[num].capa |=
RTE_ETH_FEC_MODE_CAPA_MASK(BASER);
@@ -2408,8 +2409,7 @@ sfc_fec_get_capa_speed_to_fec(uint32_t supported_caps,
if (speed_fec_capa != NULL) {
speed_fec_capa[num].speed = RTE_ETH_SPEED_NUM_40G;
speed_fec_capa[num].capa =
- RTE_ETH_FEC_MODE_CAPA_MASK(NOFEC) |
- RTE_ETH_FEC_MODE_CAPA_MASK(AUTO);
+ RTE_ETH_FEC_MODE_CAPA_MASK(NOFEC);
if (baser) {
speed_fec_capa[num].capa |=
RTE_ETH_FEC_MODE_CAPA_MASK(BASER);
@@ -2421,8 +2421,7 @@ sfc_fec_get_capa_speed_to_fec(uint32_t supported_caps,
if (speed_fec_capa != NULL) {
speed_fec_capa[num].speed = RTE_ETH_SPEED_NUM_50G;
speed_fec_capa[num].capa =
- RTE_ETH_FEC_MODE_CAPA_MASK(NOFEC) |
- RTE_ETH_FEC_MODE_CAPA_MASK(AUTO);
+ RTE_ETH_FEC_MODE_CAPA_MASK(NOFEC);
if (baser) {
speed_fec_capa[num].capa |=
RTE_ETH_FEC_MODE_CAPA_MASK(BASER);
@@ -2438,8 +2437,7 @@ sfc_fec_get_capa_speed_to_fec(uint32_t supported_caps,
if (speed_fec_capa != NULL) {
speed_fec_capa[num].speed = RTE_ETH_SPEED_NUM_100G;
speed_fec_capa[num].capa =
- RTE_ETH_FEC_MODE_CAPA_MASK(NOFEC) |
- RTE_ETH_FEC_MODE_CAPA_MASK(AUTO);
+ RTE_ETH_FEC_MODE_CAPA_MASK(NOFEC);
if (rs) {
speed_fec_capa[num].capa |=
RTE_ETH_FEC_MODE_CAPA_MASK(RS);
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-02-20 14:55:44.571976012 +0000
+++ 0032-net-sfc-drop-AUTO-from-FEC-capabilities-and-fix-comm.patch 2026-02-20 14:55:43.204191074 +0000
@@ -1 +1 @@
-From a0d1eb6a4e1b8be4cd6209c1186d28ec373611de Mon Sep 17 00:00:00 2001
+From 928d341916e3a3c7340962749bcac39819abec13 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit a0d1eb6a4e1b8be4cd6209c1186d28ec373611de ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -16,2 +17,2 @@
- drivers/net/sfc/sfc_ethdev.c | 31 ++++++++++++++-----------------
- 1 file changed, 14 insertions(+), 17 deletions(-)
+ drivers/net/sfc/sfc_ethdev.c | 28 +++++++++++++---------------
+ 1 file changed, 13 insertions(+), 15 deletions(-)
@@ -20 +21 @@
-index fc759f52fe..7c2abaab6b 100644
+index 52575c817a..d4e997bcef 100644
@@ -23 +24 @@
-@@ -2517,18 +2517,20 @@ sfc_fec_get_capa_speed_to_fec(uint32_t supported_caps,
+@@ -2368,18 +2368,20 @@ sfc_fec_get_capa_speed_to_fec(uint32_t supported_caps,
@@ -51 +52 @@
-@@ -2540,8 +2542,7 @@ sfc_fec_get_capa_speed_to_fec(uint32_t supported_caps,
+@@ -2391,8 +2393,7 @@ sfc_fec_get_capa_speed_to_fec(uint32_t supported_caps,
@@ -61 +62 @@
-@@ -2557,8 +2558,7 @@ sfc_fec_get_capa_speed_to_fec(uint32_t supported_caps,
+@@ -2408,8 +2409,7 @@ sfc_fec_get_capa_speed_to_fec(uint32_t supported_caps,
@@ -71 +72 @@
-@@ -2570,8 +2570,7 @@ sfc_fec_get_capa_speed_to_fec(uint32_t supported_caps,
+@@ -2421,8 +2421,7 @@ sfc_fec_get_capa_speed_to_fec(uint32_t supported_caps,
@@ -81 +82 @@
-@@ -2587,8 +2586,7 @@ sfc_fec_get_capa_speed_to_fec(uint32_t supported_caps,
+@@ -2438,8 +2437,7 @@ sfc_fec_get_capa_speed_to_fec(uint32_t supported_caps,
@@ -84,10 +84,0 @@
- speed_fec_capa[num].capa =
-- RTE_ETH_FEC_MODE_CAPA_MASK(NOFEC) |
-- RTE_ETH_FEC_MODE_CAPA_MASK(AUTO);
-+ RTE_ETH_FEC_MODE_CAPA_MASK(NOFEC);
- if (rs) {
- speed_fec_capa[num].capa |=
- RTE_ETH_FEC_MODE_CAPA_MASK(RS);
-@@ -2600,8 +2598,7 @@ sfc_fec_get_capa_speed_to_fec(uint32_t supported_caps,
- if (speed_fec_capa != NULL) {
- speed_fec_capa[num].speed = RTE_ETH_SPEED_NUM_200G;
More information about the stable
mailing list