patch 'net/ice: check null scheduler root node' has been queued to stable release 24.11.5
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Fri Feb 20 15:55:57 CET 2026
Hi,
FYI, your patch has been queued to stable release 24.11.5
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/22/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/02618cab1beba26e619442280f4345be9a50b700
Thanks.
Luca Boccassi
---
>From 02618cab1beba26e619442280f4345be9a50b700 Mon Sep 17 00:00:00 2001
From: Ciara Loftus <ciara.loftus at intel.com>
Date: Thu, 15 Jan 2026 10:38:21 +0000
Subject: [PATCH] net/ice: check null scheduler root node
[ upstream commit 17f994ba82dd8031958729ea1be4e6b641baa7e9 ]
When committing a new Tx scheduler hierarchy we assume the user has
created a root node. However if they have not, it leads to an invalid
memory access. While this would be an invalid configuration by the user
we should still prevent the invalid memory access from happening. Do so
by ensuring the root node is non null before dereferencing.
Fixes: 715d449a965b ("net/ice: enhance Tx scheduler hierarchy support")
Signed-off-by: Ciara Loftus <ciara.loftus at intel.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
drivers/net/ice/ice_tm.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c
index f2d8e12181..db895613cc 100644
--- a/drivers/net/ice/ice_tm.c
+++ b/drivers/net/ice/ice_tm.c
@@ -816,8 +816,13 @@ commit_new_hierarchy(struct rte_eth_dev *dev)
uint16_t nodes_created_per_level[ICE_TM_MAX_LAYERS] = {0};
uint8_t q_lvl = ice_get_leaf_level(pf);
uint8_t qg_lvl = q_lvl - 1;
-
struct ice_sched_node *new_vsi_root = hw->vsi_ctx[pf->main_vsi->idx]->sched.vsi_node[0];
+
+ if (sw_root == NULL) {
+ PMD_DRV_LOG(ERR, "No root node defined in TM hierarchy");
+ return -1;
+ }
+
/* handle case where VSI node needs to move DOWN the hierarchy */
while (new_vsi_root->tx_sched_layer < new_root_level) {
if (new_vsi_root->num_children == 0)
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-02-20 14:55:45.397380306 +0000
+++ 0055-net-ice-check-null-scheduler-root-node.patch 2026-02-20 14:55:43.244191751 +0000
@@ -1 +1 @@
-From 17f994ba82dd8031958729ea1be4e6b641baa7e9 Mon Sep 17 00:00:00 2001
+From 02618cab1beba26e619442280f4345be9a50b700 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 17f994ba82dd8031958729ea1be4e6b641baa7e9 ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -18 +19 @@
- drivers/net/intel/ice/ice_tm.c | 7 ++++++-
+ drivers/net/ice/ice_tm.c | 7 ++++++-
@@ -21 +22 @@
-diff --git a/drivers/net/intel/ice/ice_tm.c b/drivers/net/intel/ice/ice_tm.c
+diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c
@@ -23,2 +24,2 @@
---- a/drivers/net/intel/ice/ice_tm.c
-+++ b/drivers/net/intel/ice/ice_tm.c
+--- a/drivers/net/ice/ice_tm.c
++++ b/drivers/net/ice/ice_tm.c
More information about the stable
mailing list